[NFC][webkit.UncountedLambdaCapturesChecker] Remove unnecessary check (#120069)

Fznamznon · web-flow · commit e5a6f1c77934 · 2024-12-17T10:45:10.000+01:00
CXXMD is checked for null, but it can't be null inside of a visitor's
method. Found by a static analyzer tool.
diff --git a/clang/lib/StaticAnalyzer/Checkers/WebKit/UncountedLambdaCapturesChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/WebKit/UncountedLambdaCapturesChecker.cpp
@@ -52,7 +52,7 @@ class UncountedLambdaCapturesChecker
 
       bool TraverseCXXMethodDecl(CXXMethodDecl *CXXMD) override {
         llvm::SaveAndRestore SavedDecl(ClsType);
-        if (CXXMD && CXXMD->isInstance())
+        if (CXXMD->isInstance())
           ClsType = CXXMD->getThisType();
         return DynamicRecursiveASTVisitor::TraverseCXXMethodDecl(CXXMD);
       }

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ class UncountedLambdaCapturesChecker`
`52`	`52`
`53`	`53`	`bool TraverseCXXMethodDecl(CXXMethodDecl *CXXMD) override {`
`54`	`54`	`llvm::SaveAndRestore SavedDecl(ClsType);`
`55`		`- if (CXXMD && CXXMD->isInstance())`
	`55`	`+ if (CXXMD->isInstance())`
`56`	`56`	`ClsType = CXXMD->getThisType();`
`57`	`57`	`return DynamicRecursiveASTVisitor::TraverseCXXMethodDecl(CXXMD);`
`58`	`58`	`}`