Skip to content

Commit e5db5e6

Browse files
Address some errors from gcc regarding inlining
1 parent 5d8b788 commit e5db5e6

File tree

2 files changed

+4
-11
lines changed

2 files changed

+4
-11
lines changed

libcxx/src/stacktrace/stacktrace.cpp

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -55,13 +55,6 @@ _LIBCPP_EXPORTED_FROM_ABI ostream& operator<<(ostream& __os, const stacktrace_en
5555

5656
namespace __stacktrace {
5757

58-
/* Anchors for classes w/ vtables */
59-
// alloc::~alloc() = default;
60-
debug::~debug() = default;
61-
debug::dummy_ostream::~dummy_ostream() = default;
62-
fd_streambuf::~fd_streambuf() = default;
63-
fd_istream::~fd_istream() = default;
64-
6558
/*
6659
* `to_string` Helpers
6760
*/

libcxx/src/stacktrace/utils.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ struct failed : std::runtime_error {
3434
or as a macro with exactly the string `1` then this is enabled (prints to `std::cerr`);
3535
otherwise its does nothing by returning a dummy stream. */
3636
struct _LIBCPP_HIDE_FROM_ABI debug : std::ostream {
37-
_LIBCPP_HIDE_FROM_ABI virtual ~debug();
37+
_LIBCPP_HIDE_FROM_ABI virtual ~debug() = default;
3838

3939
_LIBCPP_HIDE_FROM_ABI static bool enabled() {
4040
#if defined(LIBCXX_STACKTRACE_DEBUG) && LIBCXX_STACKTRACE_DEBUG == 1
@@ -50,7 +50,7 @@ struct _LIBCPP_HIDE_FROM_ABI debug : std::ostream {
5050

5151
/** No-op output stream. */
5252
struct _LIBCPP_HIDE_FROM_ABI dummy_ostream final : std::ostream {
53-
_LIBCPP_HIDE_FROM_ABI virtual ~dummy_ostream();
53+
_LIBCPP_HIDE_FROM_ABI virtual ~dummy_ostream() = default;
5454
friend std::ostream& operator<<(dummy_ostream& bogus, auto const&) { return bogus; }
5555
};
5656

@@ -123,14 +123,14 @@ struct _LIBCPP_HIDE_FROM_ABI fd_streambuf final : std::streambuf {
123123
char* buf_;
124124
size_t size_;
125125
_LIBCPP_HIDE_FROM_ABI fd_streambuf(fd& fd, char* buf, size_t size) : fd_(fd), buf_(buf), size_(size) {}
126-
_LIBCPP_HIDE_FROM_ABI virtual ~fd_streambuf();
126+
_LIBCPP_HIDE_FROM_ABI virtual ~fd_streambuf() = default;
127127
_LIBCPP_HIDE_FROM_ABI int underflow() override;
128128
};
129129

130130
/** Wraps an `FDInStreamBuffer` in an `istream` */
131131
struct fd_istream final : std::istream {
132132
fd_streambuf& buf_;
133-
_LIBCPP_HIDE_FROM_ABI virtual ~fd_istream();
133+
_LIBCPP_HIDE_FROM_ABI virtual ~fd_istream() = default;
134134
_LIBCPP_HIDE_FROM_ABI explicit fd_istream(fd_streambuf& buf) : std::istream(nullptr), buf_(buf) { rdbuf(&buf_); }
135135
};
136136

0 commit comments

Comments
 (0)