[lld-macho] Address Feedback #2

Author: Alex B

lld/MachO/SyntheticSections.cpp

@@ -836,9 +836,9 @@ void ObjCSelRefsSection::initialize() {
   }
 }
 
-ConcatInputSection *ObjCSelRefsSection::makeSelRef(StringRef methName) {
+ConcatInputSection *ObjCSelRefsSection::makeSelRef(StringRef methname) {
   auto methnameOffset =
-      in.objcMethnameSection->getStringOffset(methName).outSecOff;
+      in.objcMethnameSection->getStringOffset(methname).outSecOff;
 
   size_t wordSize = target->wordSize;
   uint8_t *selrefData = bAlloc().Allocate<uint8_t>(wordSize);
@@ -857,12 +857,12 @@ ConcatInputSection *ObjCSelRefsSection::makeSelRef(StringRef methName) {
   objcSelref->parent = ConcatOutputSection::getOrCreateForInput(objcSelref);
   inputSections.push_back(objcSelref);
   objcSelref->isFinal = true;
-  methnameToSelref[CachedHashStringRef(methName)] = objcSelref;
+  methnameToSelref[CachedHashStringRef(methname)] = objcSelref;
   return objcSelref;
 }
 
-ConcatInputSection *ObjCSelRefsSection::getSelRef(StringRef methName) {
-  auto it = methnameToSelref.find(CachedHashStringRef(methName));
+ConcatInputSection *ObjCSelRefsSection::getSelRef(StringRef methname) {
+  auto it = methnameToSelref.find(CachedHashStringRef(methname));
   if (it == methnameToSelref.end())
     return nullptr;
   return it->second;

lld/MachO/SyntheticSections.h

@@ -320,14 +320,16 @@ class ObjCSelRefsSection final : public SyntheticSection {
   ObjCSelRefsSection();
   void initialize();
 
-  // This SyntheticSection does not do its own writing, but instead uses the
-  // creates SyntheticInputSection's and inserts them into inputSections
+  // This SyntheticSection does not do directly write data to the output, it is
+  // just a placeholder for easily creating SyntheticInputSection's which will
+  // be inserted into inputSections and handeled by the default writing
+  // mechanism.
   uint64_t getSize() const override { return 0; }
   bool isNeeded() const override { return false; }
   void writeTo(uint8_t *buf) const override {}
 
-  ConcatInputSection *getSelRef(StringRef methName);
-  ConcatInputSection *makeSelRef(StringRef methName);
+  ConcatInputSection *getSelRef(StringRef methname);
+  ConcatInputSection *makeSelRef(StringRef methname);
 
 private:
   llvm::DenseMap<llvm::CachedHashStringRef, ConcatInputSection *>