Correctly diagnose array 'new' with initialization arguments when the new type is a typedef to an array type.

Anders Carlsson · Anders Carlsson · commit e6ae81b0a201 · 2010-05-16T16:24:20.000Z
llvm-svn: 103909
diff --git a/clang/lib/Sema/SemaExprCXX.cpp b/clang/lib/Sema/SemaExprCXX.cpp
@@ -760,7 +760,7 @@ Sema::BuildCXXNew(SourceLocation StartLoc, bool UseGlobal,
   ASTOwningVector<&ActionBase::DeleteExpr> ConvertedConstructorArgs(*this);
 
   // Array 'new' can't have any initializers.
-  if (NumConsArgs && ArraySize) {
+  if (NumConsArgs && (ResultType->isArrayType() || ArraySize)) {
     SourceRange InitRange(ConsArgs[0]->getLocStart(),
                           ConsArgs[NumConsArgs - 1]->getLocEnd());
     
diff --git a/clang/test/SemaCXX/new-delete.cpp b/clang/test/SemaCXX/new-delete.cpp
@@ -245,6 +245,9 @@ namespace Test1 {
 
 void f() {
   (void)new int[10](1, 2); // expected-error {{array 'new' cannot have initialization arguments}}
+  
+  typedef int T[10];
+  (void)new T(1, 2); // expected-error {{array 'new' cannot have initialization arguments}}
 }
 
 template<typename T>

Original file line number	Diff line number	Diff line change
`@@ -245,6 +245,9 @@ namespace Test1 {`
`245`	`245`
`246`	`246`	`void f() {`
`247`	`247`	`(void)new int[10](1, 2); // expected-error {{array 'new' cannot have initialization arguments}}`
	`248`	`+`
	`249`	`+ typedef int T[10];`
	`250`	`+ (void)new T(1, 2); // expected-error {{array 'new' cannot have initialization arguments}}`
`248`	`251`	`}`
`249`	`252`
`250`	`253`	`template<typename T>`