Skip to content

Commit e739a33

Browse files
author
Bharadwaj Yadavalli
committed
missed changes from PR feedback
1 parent ab2eae1 commit e739a33

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

llvm/lib/CodeGen/CommandFlags.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -744,7 +744,7 @@ void codegen::setFunctionAttributes(StringRef CPU, StringRef Features,
744744
Expected<std::unique_ptr<TargetMachine>>
745745
codegen::createTargetMachineForTriple(StringRef TargetTriple,
746746
CodeGenOptLevel OptLevel) {
747-
Triple TheTriple(TargetTriple.str());
747+
Triple TheTriple(TargetTriple);
748748
std::string Error;
749749
const auto *TheTarget =
750750
TargetRegistry::lookupTarget(codegen::getMArch(), TheTriple, Error);

llvm/lib/TargetParser/Triple.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,8 +137,9 @@ StringRef Triple::getArchName(ArchType Kind, SubArchType SubArch) {
137137
case Triple::DXILSubArch_v1_8:
138138
return "dxilv1.8";
139139
default:
140-
return "";
140+
break;
141141
}
142+
break;
142143
default:
143144
break;
144145
}

0 commit comments

Comments
 (0)