fix: readig symbol table should be done once per file, not per symbol section!

sivan-shani · sivan-shani · commit e73a6bd8fce5 · 2025-03-19T17:19:26.000Z
diff --git a/lld/ELF/InputFiles.cpp b/lld/ELF/InputFiles.cpp
@@ -873,10 +873,9 @@ template <class ELFT> void ObjFile<ELFT>::parse(bool ignoreComdats) {
         sections[i] = &InputSection::discarded;
     } break;
     }
-
-    // Read a symbol table.
-    initializeSymbols(obj);
   }
+  // Read a symbol table.
+  initializeSymbols(obj);
 }
 
 // Sections with SHT_GROUP and comdat bits define comdat section groups.

Original file line number	Diff line number	Diff line change
`@@ -873,10 +873,9 @@ template <class ELFT> void ObjFile<ELFT>::parse(bool ignoreComdats) {`
`873`	`873`	`sections[i] = &InputSection::discarded;`
`874`	`874`	`} break;`
`875`	`875`	`}`
`876`		`-`
`877`		`- // Read a symbol table.`
`878`		`- initializeSymbols(obj);`
`879`	`876`	`}`
	`877`	`+ // Read a symbol table.`
	`878`	`+ initializeSymbols(obj);`
`880`	`879`	`}`
`881`	`880`
`882`	`881`	`// Sections with SHT_GROUP and comdat bits define comdat section groups.`