Skip to content

Commit e73c4d1

Browse files
committed
change variable names
1 parent 299a64d commit e73c4d1

File tree

4 files changed

+14
-32
lines changed

4 files changed

+14
-32
lines changed

llvm/lib/Target/AMDGPU/AMDGPUInsertDelayAlu.cpp

Lines changed: 8 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,7 @@
1616
#include "MCTargetDesc/AMDGPUMCTargetDesc.h"
1717
#include "SIDefines.h"
1818
#include "SIInstrInfo.h"
19-
#include "Utils/AMDGPUBaseInfo.h"
2019
#include "llvm/ADT/SetVector.h"
21-
#include "llvm/CodeGen/MachineInstr.h"
22-
#include "llvm/MC/MCRegister.h"
23-
#include "llvm/Support/ErrorHandling.h"
24-
2520
using namespace llvm;
2621

2722
#define DEBUG_TYPE "amdgpu-insert-delay-alu"
@@ -56,10 +51,7 @@ class AMDGPUInsertDelayAlu {
5651
// These instruction types wait for VA_SDST==0 before issuing.
5752
const uint64_t VA_SDST_0 = SIInstrFlags::SALU | SIInstrFlags::SMRD;
5853

59-
if (MI.getDesc().TSFlags & VA_SDST_0)
60-
return true;
61-
62-
return false;
54+
return MI.getDesc().TSFlags & VA_SDST_0;
6355
}
6456

6557
// Types of delay that can be encoded in an s_delay_alu instruction.
@@ -242,12 +234,11 @@ class AMDGPUInsertDelayAlu {
242234
}
243235
}
244236

245-
void advanceByNum(DelayType Type, unsigned Cycles,
246-
unsigned SGPRWriteVALUNum) {
237+
void advanceByVALUNum(unsigned VALUNum) {
247238
iterator Next;
248239
for (auto I = begin(), E = end(); I != E; I = Next) {
249240
Next = std::next(I);
250-
if (I->second.VALUNum >= SGPRWriteVALUNum && I->second.VALUCycles > 0) {
241+
if (I->second.VALUNum >= VALUNum && I->second.VALUCycles > 0) {
251242
erase(I);
252243
}
253244
}
@@ -357,7 +348,7 @@ class AMDGPUInsertDelayAlu {
357348
bool Changed = false;
358349
MachineInstr *LastDelayAlu = nullptr;
359350

360-
MCRegUnit lastSGPRfromVALU = 0;
351+
MCRegUnit LastSGPRFromVALU = 0;
361352
// Iterate over the contents of bundles, but don't emit any instructions
362353
// inside a bundle.
363354
for (auto &MI : MBB.instrs()) {
@@ -373,11 +364,11 @@ class AMDGPUInsertDelayAlu {
373364
DelayType Type = getDelayType(MI.getDesc().TSFlags);
374365

375366
if (instructionWaitsForSGPRWrites(MI)) {
376-
auto It = State.find(lastSGPRfromVALU);
367+
auto It = State.find(LastSGPRFromVALU);
377368
if (It != State.end()) {
378369
DelayInfo Info = It->getSecond();
379-
State.advanceByNum(VALU, Info.VALUCycles, Info.VALUNum);
380-
lastSGPRfromVALU = 0;
370+
State.advanceByVALUNum(Info.VALUNum);
371+
LastSGPRFromVALU = 0;
381372
}
382373
}
383374

@@ -409,7 +400,7 @@ class AMDGPUInsertDelayAlu {
409400
for (const auto &Op : MI.defs()) {
410401
Register Reg = Op.getReg();
411402
if (AMDGPU::isSGPR(Reg, TRI)) {
412-
lastSGPRfromVALU = *(TRI->regunits(Reg).begin());
403+
LastSGPRFromVALU = *TRI->regunits(Reg).begin();
413404
break;
414405
}
415406
}

llvm/test/CodeGen/AMDGPU/buffer-fat-pointers-memcpy.ll

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -923,7 +923,6 @@ define amdgpu_kernel void @memcpy_known_medium(ptr addrspace(7) inreg %src, ptr
923923
; SDAG-GFX1100-NEXT: v_add_nc_u32_e32 v61, s0, v0
924924
; SDAG-GFX1100-NEXT: v_add_nc_u32_e32 v65, s8, v0
925925
; SDAG-GFX1100-NEXT: v_add_co_u32 v0, s1, 0x100, v0
926-
; SDAG-GFX1100-NEXT: s_delay_alu instid0(VALU_DEP_1)
927926
; SDAG-GFX1100-NEXT: s_and_b32 vcc_lo, exec_lo, s1
928927
; SDAG-GFX1100-NEXT: s_clause 0xf
929928
; SDAG-GFX1100-NEXT: buffer_load_b128 v[1:4], v61, s[4:7], 0 offen
@@ -1097,7 +1096,6 @@ define amdgpu_kernel void @memcpy_known_medium(ptr addrspace(7) inreg %src, ptr
10971096
; GISEL-GFX1100-NEXT: v_add_nc_u32_e32 v61, s0, v0
10981097
; GISEL-GFX1100-NEXT: v_add_nc_u32_e32 v65, s8, v0
10991098
; GISEL-GFX1100-NEXT: v_add_co_u32 v0, s1, 0x100, v0
1100-
; GISEL-GFX1100-NEXT: s_delay_alu instid0(VALU_DEP_1)
11011099
; GISEL-GFX1100-NEXT: s_xor_b32 s1, s1, -1
11021100
; GISEL-GFX1100-NEXT: s_clause 0xf
11031101
; GISEL-GFX1100-NEXT: buffer_load_b128 v[1:4], v61, s[4:7], 0 offen

llvm/test/CodeGen/AMDGPU/llvm.amdgcn.readfirstlane.m0.ll

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ define void @test_readfirstlane_m0(i32 %arg) {
2222
; GFX11: ; %bb.0:
2323
; GFX11-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0)
2424
; GFX11-NEXT: v_readfirstlane_b32 s0, v0
25-
; GFX11-NEXT: s_delay_alu instid0(VALU_DEP_1)
2625
; GFX11-NEXT: s_mov_b32 m0, s0
2726
; GFX11-NEXT: s_sendmsg sendmsg(MSG_INTERRUPT)
2827
; GFX11-NEXT: s_waitcnt lgkmcnt(0)

llvm/test/CodeGen/AMDGPU/llvm.amdgcn.s.ttracedata.ll

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -26,18 +26,12 @@ define amdgpu_cs void @ttracedata_s(i32 inreg %val) {
2626
}
2727

2828
define amdgpu_cs void @ttracedata_v(i32 %val) {
29-
; GFX11-SDAG-LABEL: ttracedata_v:
30-
; GFX11-SDAG: ; %bb.0:
31-
; GFX11-SDAG-NEXT: v_readfirstlane_b32 s0, v0
32-
; GFX11-SDAG-NEXT: s_mov_b32 m0, s0
33-
; GFX11-SDAG-NEXT: s_ttracedata
34-
; GFX11-SDAG-NEXT: s_endpgm
35-
;
36-
; GFX11-GISEL-LABEL: ttracedata_v:
37-
; GFX11-GISEL: ; %bb.0:
38-
; GFX11-GISEL-NEXT: v_readfirstlane_b32 m0, v0
39-
; GFX11-GISEL-NEXT: s_ttracedata
40-
; GFX11-GISEL-NEXT: s_endpgm
29+
; GFX11-LABEL: ttracedata_v:
30+
; GFX11: ; %bb.0:
31+
; GFX11-NEXT: v_readfirstlane_b32 s0, v0
32+
; GFX11-NEXT: s_mov_b32 m0, s0
33+
; GFX11-NEXT: s_ttracedata
34+
; GFX11-NEXT: s_endpgm
4135
call void @llvm.amdgcn.s.ttracedata(i32 %val)
4236
ret void
4337
}

0 commit comments

Comments
 (0)