Skip to content

Commit e75bba9

Browse files
committed
address pr comments, add run spirv validator if spirv-tools exist
1 parent d21b77f commit e75bba9

File tree

22 files changed

+44
-23
lines changed

22 files changed

+44
-23
lines changed

llvm/test/CodeGen/SPIRV/hlsl-intrinsics/abs.ll

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
; RUN: llc -O0 -mtriple=spirv-unknown-linux %s -o - | FileCheck %s
1+
; RUN: llc -O0 -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s
2+
; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-unknown %s -o - -filetype=obj | spirv-val %}
23

34
; CHECK: OpExtInstImport "GLSL.std.450"
45

llvm/test/CodeGen/SPIRV/hlsl-intrinsics/ceil.ll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
; RUN: llc -O0 -mtriple=spirv-unknown-linux %s -o - | FileCheck %s
2-
1+
; RUN: llc -O0 -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s
2+
; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-unknown %s -o - -filetype=obj | spirv-val %}
33
; CHECK: OpExtInstImport "GLSL.std.450"
44

55
define noundef float @ceil_float(float noundef %a) {

llvm/test/CodeGen/SPIRV/hlsl-intrinsics/cos.ll

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
; RUN: llc -O0 -mtriple=spirv-unknown-linux %s -o - | FileCheck %s
1+
; RUN: llc -O0 -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s
2+
; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-unknown %s -o - -filetype=obj | spirv-val %}
23

34
; CHECK: OpExtInstImport "GLSL.std.450"
45

llvm/test/CodeGen/SPIRV/hlsl-intrinsics/exp.ll

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
; RUN: llc -O0 -mtriple=spirv-unknown-linux %s -o - | FileCheck %s
1+
; RUN: llc -O0 -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s
2+
; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-unknown %s -o - -filetype=obj | spirv-val %}
23

34
; CHECK: OpExtInstImport "GLSL.std.450"
45

llvm/test/CodeGen/SPIRV/hlsl-intrinsics/exp2.ll

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
; RUN: llc -O0 -mtriple=spirv-unknown-linux %s -o - | FileCheck %s
1+
; RUN: llc -O0 -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s
2+
; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-unknown %s -o - -filetype=obj | spirv-val %}
23

34
; CHECK: OpExtInstImport "GLSL.std.450"
45

llvm/test/CodeGen/SPIRV/hlsl-intrinsics/floor.ll

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
; RUN: llc -O0 -mtriple=spirv-unknown-linux %s -o - | FileCheck %s
1+
; RUN: llc -O0 -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s
2+
; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-unknown %s -o - -filetype=obj | spirv-val %}
23

34
; CHECK: OpExtInstImport "GLSL.std.450"
45

llvm/test/CodeGen/SPIRV/hlsl-intrinsics/fmad.ll

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
; RUN: llc -O0 -mtriple=spirv-unknown-linux %s -o - | FileCheck %s
1+
; RUN: llc -O0 -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s
2+
; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-unknown %s -o - -filetype=obj | spirv-val %}
23

34
; CHECK: OpExtInstImport "GLSL.std.450"
45

llvm/test/CodeGen/SPIRV/hlsl-intrinsics/fmax.ll

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
; RUN: llc -O0 -mtriple=spirv-unknown-linux %s -o - | FileCheck %s
1+
; RUN: llc -O0 -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s
2+
; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-unknown %s -o - -filetype=obj | spirv-val %}
23

34
; CHECK: OpExtInstImport "GLSL.std.450"
45

llvm/test/CodeGen/SPIRV/hlsl-intrinsics/fmin.ll

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
; RUN: llc -O0 -mtriple=spirv-unknown-linux %s -o - | FileCheck %s
1+
; RUN: llc -O0 -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s
2+
; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-unknown %s -o - -filetype=obj | spirv-val %}
23

34
; CHECK: OpExtInstImport "GLSL.std.450"
45
; CHECK: OpMemoryModel Logical GLSL450

llvm/test/CodeGen/SPIRV/hlsl-intrinsics/log.ll

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
; RUN: llc -O0 -mtriple=spirv-unknown-linux %s -o - | FileCheck %s
1+
; RUN: llc -O0 -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s
2+
; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-unknown %s -o - -filetype=obj | spirv-val %}
23

34
; CHECK: OpExtInstImport "GLSL.std.450"
45

llvm/test/CodeGen/SPIRV/hlsl-intrinsics/log10.ll

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
; RUN: llc -O0 -mtriple=spirv-unknown-linux %s -o - | FileCheck %s
1+
; RUN: llc -O0 -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s
2+
; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-unknown %s -o - -filetype=obj | spirv-val %}
23

34
; CHECK: %[[#extinst:]] = OpExtInstImport "GLSL.std.450"
45

llvm/test/CodeGen/SPIRV/hlsl-intrinsics/log2.ll

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
; RUN: llc -O0 -mtriple=spirv-unknown-linux %s -o - | FileCheck %s
1+
; RUN: llc -O0 -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s
2+
; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-unknown %s -o - -filetype=obj | spirv-val %}
23

34
; CHECK: OpExtInstImport "GLSL.std.450"
45

llvm/test/CodeGen/SPIRV/hlsl-intrinsics/pow.ll

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
; RUN: llc -O0 -mtriple=spirv-unknown-linux %s -o - | FileCheck %s
1+
; RUN: llc -O0 -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s
2+
; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-unknown %s -o - -filetype=obj | spirv-val %}
23

34
; CHECK: OpExtInstImport "GLSL.std.450"
45

llvm/test/CodeGen/SPIRV/hlsl-intrinsics/reversebits.ll

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
; RUN: llc -O0 -mtriple=spirv-unknown-linux %s -o - | FileCheck %s
1+
; RUN: llc -O0 -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s
2+
; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-unknown %s -o - -filetype=obj | spirv-val %}
23

34
; CHECK: OpMemoryModel Logical GLSL450
45

llvm/test/CodeGen/SPIRV/hlsl-intrinsics/round.ll

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
; RUN: llc -O0 -mtriple=spirv-unknown-linux %s -o - | FileCheck %s
1+
; RUN: llc -O0 -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s
2+
; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-unknown %s -o - -filetype=obj | spirv-val %}
23

34
; CHECK: OpExtInstImport "GLSL.std.450"
45

llvm/test/CodeGen/SPIRV/hlsl-intrinsics/sin.ll

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
; RUN: llc -O0 -mtriple=spirv-unknown-linux %s -o - | FileCheck %s
1+
; RUN: llc -O0 -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s
2+
; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-unknown %s -o - -filetype=obj | spirv-val %}
23

34
; CHECK: OpExtInstImport "GLSL.std.450"
45

llvm/test/CodeGen/SPIRV/hlsl-intrinsics/smax.ll

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
; RUN: llc -O0 -mtriple=spirv-unknown-linux %s -o - | FileCheck %s
1+
; RUN: llc -O0 -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s
2+
; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-unknown %s -o - -filetype=obj | spirv-val %}
23

34
; CHECK: OpExtInstImport "GLSL.std.450"
45

llvm/test/CodeGen/SPIRV/hlsl-intrinsics/smin.ll

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
; RUN: llc -O0 -mtriple=spirv-unknown-linux %s -o - | FileCheck %s
1+
; RUN: llc -O0 -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s
2+
; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-unknown %s -o - -filetype=obj | spirv-val %}
23

34
; CHECK: OpExtInstImport "GLSL.std.450"
45

llvm/test/CodeGen/SPIRV/hlsl-intrinsics/sqrt.ll

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
; RUN: llc -O0 -mtriple=spirv-unknown-linux %s -o - | FileCheck %s
1+
; RUN: llc -O0 -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s
2+
; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-unknown %s -o - -filetype=obj | spirv-val %}
23

34
; CHECK: OpExtInstImport "GLSL.std.450"
45

llvm/test/CodeGen/SPIRV/hlsl-intrinsics/trunc.ll

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
; RUN: llc -O0 -mtriple=spirv-unknown-linux %s -o - | FileCheck %s
1+
; RUN: llc -O0 -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s
2+
; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-unknown %s -o - -filetype=obj | spirv-val %}
23

34
; CHECK: OpExtInstImport "GLSL.std.450"
45

llvm/test/CodeGen/SPIRV/hlsl-intrinsics/umax.ll

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
; RUN: llc -O0 -mtriple=spirv-unknown-linux %s -o - | FileCheck %s
1+
; RUN: llc -O0 -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s
2+
; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-unknown %s -o - -filetype=obj | spirv-val %}
23

34
; CHECK: OpExtInstImport "GLSL.std.450"
45

llvm/test/CodeGen/SPIRV/hlsl-intrinsics/umin.ll

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
; RUN: llc -O0 -mtriple=spirv-unknown-linux %s -o - | FileCheck %s
1+
; RUN: llc -O0 -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s
2+
; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-unknown %s -o - -filetype=obj | spirv-val %}
23

34
; CHECK: OpExtInstImport "GLSL.std.450"
45

0 commit comments

Comments
 (0)