[InstCombine] Fixup commit 7253c6f (#123315)

sushgokh · web-flow · commit e79bb8731ae9 · 2025-01-17T02:14:04.000-08:00
This should fix the assert failure we were getting for the darwin OS.
diff --git a/llvm/lib/Transforms/InstCombine/InstCombineMulDivRem.cpp b/llvm/lib/Transforms/InstCombine/InstCombineMulDivRem.cpp
@@ -2067,8 +2067,7 @@ convertFSqrtDivIntoFMul(CallInst *CI, Instruction *X,
   FMul->copyMetadata(*X);
   FMul->copyFastMathFlags(FastMathFlags::intersectRewrite(R1FMF, R2FMF) |
                           FastMathFlags::unionValue(R1FMF, R2FMF));
-  IC->replaceInstUsesWith(*X, FMul);
-  return IC->eraseInstFromFunction(*X);
+  return IC->replaceInstUsesWith(*X, FMul);
 }
 
 Instruction *InstCombinerImpl::visitFDiv(BinaryOperator &I) {

Original file line number	Diff line number	Diff line change
`@@ -2067,8 +2067,7 @@ convertFSqrtDivIntoFMul(CallInst CI, Instruction X,`
`2067`	`2067`	`FMul->copyMetadata(*X);`
`2068`	`2068`	`FMul->copyFastMathFlags(FastMathFlags::intersectRewrite(R1FMF, R2FMF) \|`
`2069`	`2069`	`FastMathFlags::unionValue(R1FMF, R2FMF));`
`2070`		`- IC->replaceInstUsesWith(*X, FMul);`
`2071`		`- return IC->eraseInstFromFunction(*X);`
	`2070`	`+ return IC->replaceInstUsesWith(*X, FMul);`
`2072`	`2071`	`}`
`2073`	`2072`
`2074`	`2073`	`Instruction *InstCombinerImpl::visitFDiv(BinaryOperator &I) {`