Skip to content

Commit e79cb88

Browse files
Address TOSA related review comments.
Signed-off-by: Mirza Halilcevic <[email protected]>
1 parent fd0f519 commit e79cb88

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

mlir/lib/Dialect/Tosa/Transforms/TosaValidation.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -509,8 +509,8 @@ bool TosaValidation::isValidElementType(Type type) {
509509
if (isa<FloatType>(type)) {
510510
if (profile == TosaProfileEnum::BaseInference)
511511
return false;
512-
return isa<Float32Type, Float16Type, BFloat16Type, Float8E4M3FNUZType,
513-
Float8E5M2FNUZType, Float8E4M3FNType, Float8E5M2Type>(type);
512+
return isa<Float32Type, Float16Type, BFloat16Type, Float8E4M3FNType,
513+
Float8E5M2Type>(type);
514514
}
515515
if (auto intTy = dyn_cast<IntegerType>(type)) {
516516
if (intTy.isUnsigned()) {

mlir/lib/IR/Types.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ bool Type::isF128() const { return llvm::isa<Float128Type>(*this); }
5858

5959
bool Type::isFloat() const { return llvm::isa<FloatType>(*this); }
6060

61-
/// Return true if this is an integer type with the specified width.
61+
/// Return true if this is a float type with the specified width.
6262
bool Type::isFloat(unsigned width) const {
6363
if (auto fltTy = llvm::dyn_cast<FloatType>(*this))
6464
return fltTy.getWidth() == width;

0 commit comments

Comments
 (0)