Comments

Author: speednoisemovement

lld/MachO/Driver.cpp

@@ -360,7 +360,7 @@ static InputFile *addFile(StringRef path, LoadType loadType,
                 ": Archive::children failed: " + toString(std::move(e)));
       }
     } else if (isCommandLineLoad && config->forceLoadObjC) {
-      if (file->getArchive().getNumberOfSymbols() > 0) {
+      if (file->getArchive().hasSymbolTable()) {
         for (const object::Archive::Symbol &sym : file->getArchive().symbols())
           if (sym.getName().starts_with(objc::symbol_names::klass))
             file->fetch(sym);

lld/MachO/InputFiles.cpp

@@ -2159,7 +2159,7 @@ void ArchiveFile::addLazySymbols() {
   if (file->isEmpty())
     return;
 
-  if (file->getNumberOfSymbols() == 0) {
+  if (!file->hasSymbolTable()) {
     // No index, treat each child as a lazy object file.
     Error e = Error::success();
     for (const object::Archive::Child &c : file->children(e)) {

lld/test/MachO/archive-no-index.ll

@@ -0,0 +1,23 @@
+; REQUIRES: x86
+; RUN: rm -rf %t; split-file %s %t
+
+; RUN: llvm-as %t/lib.ll -o %t/lib.o
+# RUN: llvm-mc -filetype=obj -triple=x86_64-apple-macos -o %t/main.o %t/main.s
+; RUN: llvm-ar rcST %t/lib.a %t/lib.o
+# RUN: %lld %t/main.o %t/lib.a -o %t/out
+
+;--- main.s
+.global _main
+_main:
+    call _foo    
+    mov $0, %rax
+    ret
+
+;--- lib.ll
+target triple = "x86_64-apple-darwin"
+target datalayout = "e-m:o-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
+
+define void @foo() {
+entry:
+  ret void
+}