fixup! [clang-tidy] Improved modernize-use-using by fixing a false-negative

felix642 · felix642 · commit e7dcbbcf92e8 · 2024-03-10T09:29:03.000-04:00
Fixed crash in tests
diff --git a/clang-tools-extra/clang-tidy/modernize/UseUsingCheck.cpp b/clang-tools-extra/clang-tidy/modernize/UseUsingCheck.cpp
@@ -69,7 +69,8 @@ void UseUsingCheck::check(const MatchFinder::MatchResult &Result) {
 
   if (!ParentDecl) {
     const auto *ParentDeclStmt = Result.Nodes.getNodeAs<DeclStmt>(DeclStmtName);
-    ParentDecl = ParentDeclStmt->getSingleDecl();
+    if (ParentDeclStmt)
+      ParentDecl = ParentDeclStmt->getSingleDecl();
   }
 
   if (!ParentDecl)

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,8 @@ void UseUsingCheck::check(const MatchFinder::MatchResult &Result) {`
`69`	`69`
`70`	`70`	`if (!ParentDecl) {`
`71`	`71`	`const auto *ParentDeclStmt = Result.Nodes.getNodeAs<DeclStmt>(DeclStmtName);`
`72`		`- ParentDecl = ParentDeclStmt->getSingleDecl();`
	`72`	`+ if (ParentDeclStmt)`
	`73`	`+ ParentDecl = ParentDeclStmt->getSingleDecl();`
`73`	`74`	`}`
`74`	`75`
`75`	`76`	`if (!ParentDecl)`