Skip to content

Commit e83e0c3

Browse files
committed
[LV] Add test case for #119173. NFC
This showcases a miscompile involving a widened reduction-phi.
1 parent 7475f0a commit e83e0c3

File tree

1 file changed

+50
-0
lines changed

1 file changed

+50
-0
lines changed

llvm/test/Transforms/LoopVectorize/AArch64/mul-simplification.ll

Lines changed: 50 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,59 @@ exit:
5656
%res = phi i64 [ %red.next, %loop ]
5757
ret i64 %res
5858
}
59+
60+
define i32 @add_reduction_select_operand_constant_but_non_uniform() {
61+
; CHECK-LABEL: define i32 @add_reduction_select_operand_constant_but_non_uniform() {
62+
; CHECK-NEXT: [[ENTRY:.*]]:
63+
; CHECK-NEXT: br i1 false, label %[[SCALAR_PH:.*]], label %[[VECTOR_PH:.*]]
64+
; CHECK: [[VECTOR_PH]]:
65+
; CHECK-NEXT: br label %[[VECTOR_BODY:.*]]
66+
; CHECK: [[VECTOR_BODY]]:
67+
; CHECK-NEXT: [[INDEX:%.*]] = phi i32 [ 0, %[[VECTOR_PH]] ], [ [[INDEX_NEXT:%.*]], %[[VECTOR_BODY]] ]
68+
; CHECK-NEXT: [[VEC_PHI:%.*]] = phi <4 x i32> [ <i32 42, i32 0, i32 0, i32 0>, %[[VECTOR_PH]] ], [ splat (i32 42), %[[VECTOR_BODY]] ]
69+
; CHECK-NEXT: [[VEC_PHI1:%.*]] = phi <4 x i32> [ zeroinitializer, %[[VECTOR_PH]] ], [ splat (i32 42), %[[VECTOR_BODY]] ]
70+
; CHECK-NEXT: [[INDEX_NEXT]] = add nuw i32 [[INDEX]], 8
71+
; CHECK-NEXT: [[TMP0:%.*]] = icmp eq i32 [[INDEX_NEXT]], 64
72+
; CHECK-NEXT: br i1 [[TMP0]], label %[[MIDDLE_BLOCK:.*]], label %[[VECTOR_BODY]], !llvm.loop [[LOOP4:![0-9]+]]
73+
; CHECK: [[MIDDLE_BLOCK]]:
74+
; CHECK-NEXT: [[TMP1:%.*]] = call i32 @llvm.vector.reduce.add.v4i32(<4 x i32> splat (i32 84))
75+
; CHECK-NEXT: br i1 true, label %[[EXIT:.*]], label %[[SCALAR_PH]]
76+
; CHECK: [[SCALAR_PH]]:
77+
; CHECK-NEXT: [[BC_RESUME_VAL:%.*]] = phi i32 [ 64, %[[MIDDLE_BLOCK]] ], [ 0, %[[ENTRY]] ]
78+
; CHECK-NEXT: [[BC_MERGE_RDX:%.*]] = phi i32 [ [[TMP1]], %[[MIDDLE_BLOCK]] ], [ 42, %[[ENTRY]] ]
79+
; CHECK-NEXT: br label %[[LOOP:.*]]
80+
; CHECK: [[LOOP]]:
81+
; CHECK-NEXT: [[IV:%.*]] = phi i32 [ [[BC_RESUME_VAL]], %[[SCALAR_PH]] ], [ [[ADD2_REASS:%.*]], %[[LOOP]] ]
82+
; CHECK-NEXT: [[RDX:%.*]] = phi i32 [ [[BC_MERGE_RDX]], %[[SCALAR_PH]] ], [ [[RDX_NEXT:%.*]], %[[LOOP]] ]
83+
; CHECK-NEXT: [[ADD2_REASS]] = add i32 [[IV]], 1
84+
; CHECK-NEXT: [[RDX_NEXT]] = add i32 0, [[RDX]]
85+
; CHECK-NEXT: [[CMP:%.*]] = icmp ult i32 [[ADD2_REASS]], 64
86+
; CHECK-NEXT: br i1 [[CMP]], label %[[LOOP]], label %[[EXIT]], !llvm.loop [[LOOP5:![0-9]+]]
87+
; CHECK: [[EXIT]]:
88+
; CHECK-NEXT: [[ADD_LCSSA:%.*]] = phi i32 [ [[RDX_NEXT]], %[[LOOP]] ], [ [[TMP1]], %[[MIDDLE_BLOCK]] ]
89+
; CHECK-NEXT: ret i32 [[ADD_LCSSA]]
90+
;
91+
entry:
92+
br label %loop
93+
94+
loop:
95+
%iv = phi i32 [ 0, %entry ], [ %iv.next, %loop ]
96+
%rdx = phi i32 [ 42, %entry ], [ %rdx.next, %loop ]
97+
98+
%iv.next = add i32 %iv, 1
99+
%rdx.next = add i32 0, %rdx
100+
101+
%cmp = icmp ult i32 %iv.next, 64
102+
br i1 %cmp, label %loop, label %exit
103+
104+
exit:
105+
ret i32 %rdx.next
106+
}
59107
;.
60108
; CHECK: [[LOOP0]] = distinct !{[[LOOP0]], [[META1:![0-9]+]], [[META2:![0-9]+]]}
61109
; CHECK: [[META1]] = !{!"llvm.loop.isvectorized", i32 1}
62110
; CHECK: [[META2]] = !{!"llvm.loop.unroll.runtime.disable"}
63111
; CHECK: [[LOOP3]] = distinct !{[[LOOP3]], [[META2]], [[META1]]}
112+
; CHECK: [[LOOP4]] = distinct !{[[LOOP4]], [[META1]], [[META2]]}
113+
; CHECK: [[LOOP5]] = distinct !{[[LOOP5]], [[META2]], [[META1]]}
64114
;.

0 commit comments

Comments
 (0)