Skip to content

Commit e843f02

Browse files
authored
mlir: fix incorrect usages of divideCeilSigned (#95680)
Follow up on #95087 to fix incorrect usage instances of divideCeilSigned.
1 parent 87aed82 commit e843f02

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

mlir/include/mlir/Dialect/Mesh/IR/MeshOps.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ inline int64_t shardDimension(int64_t dimSize, int64_t shardCount) {
114114
return ShapedType::kDynamic;
115115

116116
assert(dimSize % shardCount == 0);
117-
return llvm::divideCeilSigned(dimSize, shardCount);
117+
return dimSize / shardCount;
118118
}
119119

120120
// Get the size of an unsharded dimension.

mlir/lib/Conversion/LLVMCommon/MemRefBuilder.cpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -365,7 +365,7 @@ void UnrankedMemRefDescriptor::computeSizes(
365365
Value two = createIndexAttrConstant(builder, loc, indexType, 2);
366366
Value indexSize = createIndexAttrConstant(
367367
builder, loc, indexType,
368-
llvm::divideCeilSigned(typeConverter.getIndexTypeBitwidth(), 8));
368+
llvm::divideCeil(typeConverter.getIndexTypeBitwidth(), 8));
369369

370370
sizes.reserve(sizes.size() + values.size());
371371
for (auto [desc, addressSpace] : llvm::zip(values, addressSpaces)) {
@@ -378,8 +378,7 @@ void UnrankedMemRefDescriptor::computeSizes(
378378
// to data layout) into the unranked descriptor.
379379
Value pointerSize = createIndexAttrConstant(
380380
builder, loc, indexType,
381-
llvm::divideCeilSigned(typeConverter.getPointerBitwidth(addressSpace),
382-
8));
381+
llvm::divideCeil(typeConverter.getPointerBitwidth(addressSpace), 8));
383382
Value doublePointerSize =
384383
builder.create<LLVM::MulOp>(loc, indexType, two, pointerSize);
385384

mlir/lib/Conversion/MemRefToLLVM/MemRefToLLVM.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -971,7 +971,7 @@ struct MemorySpaceCastOpLowering
971971
resultUnderlyingDesc, resultElemPtrType);
972972

973973
int64_t bytesToSkip =
974-
2 * llvm::divideCeilSigned(
974+
2 * llvm::divideCeil(
975975
getTypeConverter()->getPointerBitwidth(resultAddrSpace), 8);
976976
Value bytesToSkipConst = rewriter.create<LLVM::ConstantOp>(
977977
loc, getIndexType(), rewriter.getIndexAttr(bytesToSkip));

0 commit comments

Comments
 (0)