Skip to content

Commit e8ab413

Browse files
topperctopperc
authored
[RISCV] Add capital letters to T-Head extension names in descriptions. (#99070)
This matches T-Head documentation and the capitalization we use for the RISCVSubtarget methods.
1 parent eab3738 commit e8ab413

File tree

3 files changed

+47
-47
lines changed

3 files changed

+47
-47
lines changed

‎clang/test/Driver/print-supported-extensions-riscv.c

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -154,17 +154,17 @@
154154
// CHECK-NEXT: xsfvqmaccqoq 1.0 'XSfvqmaccqoq' (SiFive Int8 Matrix Multiplication Instructions (4-by-8 and 8-by-4))
155155
// CHECK-NEXT: xsifivecdiscarddlone 1.0 'XSiFivecdiscarddlone' (SiFive sf.cdiscard.d.l1 Instruction)
156156
// CHECK-NEXT: xsifivecflushdlone 1.0 'XSiFivecflushdlone' (SiFive sf.cflush.d.l1 Instruction)
157-
// CHECK-NEXT: xtheadba 1.0 'xtheadba' (T-Head address calculation instructions)
158-
// CHECK-NEXT: xtheadbb 1.0 'xtheadbb' (T-Head basic bit-manipulation instructions)
159-
// CHECK-NEXT: xtheadbs 1.0 'xtheadbs' (T-Head single-bit instructions)
160-
// CHECK-NEXT: xtheadcmo 1.0 'xtheadcmo' (T-Head cache management instructions)
161-
// CHECK-NEXT: xtheadcondmov 1.0 'xtheadcondmov' (T-Head conditional move instructions)
162-
// CHECK-NEXT: xtheadfmemidx 1.0 'xtheadfmemidx' (T-Head FP Indexed Memory Operations)
163-
// CHECK-NEXT: xtheadmac 1.0 'xtheadmac' (T-Head Multiply-Accumulate Instructions)
164-
// CHECK-NEXT: xtheadmemidx 1.0 'xtheadmemidx' (T-Head Indexed Memory Operations)
165-
// CHECK-NEXT: xtheadmempair 1.0 'xtheadmempair' (T-Head two-GPR Memory Operations)
166-
// CHECK-NEXT: xtheadsync 1.0 'xtheadsync' (T-Head multicore synchronization instructions)
167-
// CHECK-NEXT: xtheadvdot 1.0 'xtheadvdot' (T-Head Vector Extensions for Dot)
157+
// CHECK-NEXT: xtheadba 1.0 'XTHeadBa' (T-Head address calculation instructions)
158+
// CHECK-NEXT: xtheadbb 1.0 'XTHeadBb' (T-Head basic bit-manipulation instructions)
159+
// CHECK-NEXT: xtheadbs 1.0 'XTHeadBs' (T-Head single-bit instructions)
160+
// CHECK-NEXT: xtheadcmo 1.0 'XTHeadCmo' (T-Head cache management instructions)
161+
// CHECK-NEXT: xtheadcondmov 1.0 'XTHeadCondMov' (T-Head conditional move instructions)
162+
// CHECK-NEXT: xtheadfmemidx 1.0 'XTHeadFMemIdx' (T-Head FP Indexed Memory Operations)
163+
// CHECK-NEXT: xtheadmac 1.0 'XTHeadMac' (T-Head Multiply-Accumulate Instructions)
164+
// CHECK-NEXT: xtheadmemidx 1.0 'XTHeadMemIdx' (T-Head Indexed Memory Operations)
165+
// CHECK-NEXT: xtheadmempair 1.0 'XTHeadMemPair' (T-Head two-GPR Memory Operations)
166+
// CHECK-NEXT: xtheadsync 1.0 'XTHeadSync' (T-Head multicore synchronization instructions)
167+
// CHECK-NEXT: xtheadvdot 1.0 'XTHeadVdot' (T-Head Vector Extensions for Dot)
168168
// CHECK-NEXT: xventanacondops 1.0 'XVentanaCondOps' (Ventana Conditional Ops)
169169
// CHECK-NEXT: xwchc 2.2 'Xwchc' (WCH/QingKe additional compressed opcodes)
170170
// CHECK-EMPTY:

‎llvm/lib/Target/RISCV/RISCVFeatures.td

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1006,81 +1006,81 @@ def HasVendorXVentanaCondOps : Predicate<"Subtarget->hasVendorXVentanaCondOps()"
10061006

10071007
def FeatureVendorXTHeadBa
10081008
: RISCVExtension<"xtheadba", 1, 0,
1009-
"'xtheadba' (T-Head address calculation instructions)">;
1009+
"'XTHeadBa' (T-Head address calculation instructions)">;
10101010
def HasVendorXTHeadBa : Predicate<"Subtarget->hasVendorXTHeadBa()">,
10111011
AssemblerPredicate<(all_of FeatureVendorXTHeadBa),
1012-
"'xtheadba' (T-Head address calculation instructions)">;
1012+
"'XTHeadBa' (T-Head address calculation instructions)">;
10131013

10141014
def FeatureVendorXTHeadBb
10151015
: RISCVExtension<"xtheadbb", 1, 0,
1016-
"'xtheadbb' (T-Head basic bit-manipulation instructions)">;
1016+
"'XTHeadBb' (T-Head basic bit-manipulation instructions)">;
10171017
def HasVendorXTHeadBb : Predicate<"Subtarget->hasVendorXTHeadBb()">,
10181018
AssemblerPredicate<(all_of FeatureVendorXTHeadBb),
1019-
"'xtheadbb' (T-Head basic bit-manipulation instructions)">;
1019+
"'XTHeadBb' (T-Head basic bit-manipulation instructions)">;
10201020

10211021
def FeatureVendorXTHeadBs
10221022
: RISCVExtension<"xtheadbs", 1, 0,
1023-
"'xtheadbs' (T-Head single-bit instructions)">;
1023+
"'XTHeadBs' (T-Head single-bit instructions)">;
10241024
def HasVendorXTHeadBs : Predicate<"Subtarget->hasVendorXTHeadBs()">,
10251025
AssemblerPredicate<(all_of FeatureVendorXTHeadBs),
1026-
"'xtheadbs' (T-Head single-bit instructions)">;
1026+
"'XTHeadBs' (T-Head single-bit instructions)">;
10271027

10281028
def FeatureVendorXTHeadCondMov
10291029
: RISCVExtension<"xtheadcondmov", 1, 0,
1030-
"'xtheadcondmov' (T-Head conditional move instructions)">;
1030+
"'XTHeadCondMov' (T-Head conditional move instructions)">;
10311031
def HasVendorXTHeadCondMov : Predicate<"Subtarget->hasVendorXTHeadCondMov()">,
10321032
AssemblerPredicate<(all_of FeatureVendorXTHeadCondMov),
1033-
"'xtheadcondmov' (T-Head conditional move instructions)">;
1033+
"'XTHeadCondMov' (T-Head conditional move instructions)">;
10341034

10351035
def FeatureVendorXTHeadCmo
10361036
: RISCVExtension<"xtheadcmo", 1, 0,
1037-
"'xtheadcmo' (T-Head cache management instructions)">;
1037+
"'XTHeadCmo' (T-Head cache management instructions)">;
10381038
def HasVendorXTHeadCmo : Predicate<"Subtarget->hasVendorXTHeadCmo()">,
10391039
AssemblerPredicate<(all_of FeatureVendorXTHeadCmo),
1040-
"'xtheadcmo' (T-Head cache management instructions)">;
1040+
"'XTHeadCmo' (T-Head cache management instructions)">;
10411041

10421042
def FeatureVendorXTHeadFMemIdx
10431043
: RISCVExtension<"xtheadfmemidx", 1, 0,
1044-
"'xtheadfmemidx' (T-Head FP Indexed Memory Operations)">;
1044+
"'XTHeadFMemIdx' (T-Head FP Indexed Memory Operations)">;
10451045
def HasVendorXTHeadFMemIdx : Predicate<"Subtarget->hasVendorXTHeadFMemIdx()">,
10461046
AssemblerPredicate<(all_of FeatureVendorXTHeadFMemIdx),
1047-
"'xtheadfmemidx' (T-Head FP Indexed Memory Operations)">;
1047+
"'XTHeadFMemIdx' (T-Head FP Indexed Memory Operations)">;
10481048

10491049
def FeatureVendorXTHeadMac
10501050
: RISCVExtension<"xtheadmac", 1, 0,
1051-
"'xtheadmac' (T-Head Multiply-Accumulate Instructions)">;
1051+
"'XTHeadMac' (T-Head Multiply-Accumulate Instructions)">;
10521052
def HasVendorXTHeadMac : Predicate<"Subtarget->hasVendorXTHeadMac()">,
10531053
AssemblerPredicate<(all_of FeatureVendorXTHeadMac),
1054-
"'xtheadmac' (T-Head Multiply-Accumulate Instructions)">;
1054+
"'XTHeadMac' (T-Head Multiply-Accumulate Instructions)">;
10551055

10561056
def FeatureVendorXTHeadMemIdx
10571057
: RISCVExtension<"xtheadmemidx", 1, 0,
1058-
"'xtheadmemidx' (T-Head Indexed Memory Operations)">;
1058+
"'XTHeadMemIdx' (T-Head Indexed Memory Operations)">;
10591059
def HasVendorXTHeadMemIdx : Predicate<"Subtarget->hasVendorXTHeadMemIdx()">,
10601060
AssemblerPredicate<(all_of FeatureVendorXTHeadMemIdx),
1061-
"'xtheadmemidx' (T-Head Indexed Memory Operations)">;
1061+
"'XTHeadMemIdx' (T-Head Indexed Memory Operations)">;
10621062

10631063
def FeatureVendorXTHeadMemPair
10641064
: RISCVExtension<"xtheadmempair", 1, 0,
1065-
"'xtheadmempair' (T-Head two-GPR Memory Operations)">;
1065+
"'XTHeadMemPair' (T-Head two-GPR Memory Operations)">;
10661066
def HasVendorXTHeadMemPair : Predicate<"Subtarget->hasVendorXTHeadMemPair()">,
10671067
AssemblerPredicate<(all_of FeatureVendorXTHeadMemPair),
1068-
"'xtheadmempair' (T-Head two-GPR Memory Operations)">;
1068+
"'XTHeadMemPair' (T-Head two-GPR Memory Operations)">;
10691069

10701070
def FeatureVendorXTHeadSync
10711071
: RISCVExtension<"xtheadsync", 1, 0,
1072-
"'xtheadsync' (T-Head multicore synchronization instructions)">;
1072+
"'XTHeadSync' (T-Head multicore synchronization instructions)">;
10731073
def HasVendorXTHeadSync : Predicate<"Subtarget->hasVendorXTHeadSync()">,
10741074
AssemblerPredicate<(all_of FeatureVendorXTHeadSync),
1075-
"'xtheadsync' (T-Head multicore synchronization instructions)">;
1075+
"'XTHeadSync' (T-Head multicore synchronization instructions)">;
10761076

10771077
def FeatureVendorXTHeadVdot
10781078
: RISCVExtension<"xtheadvdot", 1, 0,
1079-
"'xtheadvdot' (T-Head Vector Extensions for Dot)",
1079+
"'XTHeadVdot' (T-Head Vector Extensions for Dot)",
10801080
[FeatureStdExtV]>;
10811081
def HasVendorXTHeadVdot : Predicate<"Subtarget->hasVendorXTHeadVdot()">,
10821082
AssemblerPredicate<(all_of FeatureVendorXTHeadVdot),
1083-
"'xtheadvdot' (T-Head Vector Extensions for Dot)">;
1083+
"'XTHeadVdot' (T-Head Vector Extensions for Dot)">;
10841084

10851085
// SiFive Extensions
10861086

‎llvm/test/MC/RISCV/XTHeadVdot-valid.s

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -11,83 +11,83 @@
1111
th.vmaqau.vv v8, v20, v4, v0.t
1212
# CHECK-INST: th.vmaqau.vv v8, v20, v4, v0.t
1313
# CHECK-ENCODING: [0x0b,0x64,0x4a,0x88]
14-
# CHECK-ERROR: instruction requires the following: 'xtheadvdot' (T-Head Vector Extensions for Dot){{$}}
14+
# CHECK-ERROR: instruction requires the following: 'XTHeadVdot' (T-Head Vector Extensions for Dot){{$}}
1515
# CHECK-UNKNOWN: 884a640b <unknown>
1616

1717
th.vmaqau.vv v8, v20, v4
1818
# CHECK-INST: th.vmaqau.vv v8, v20, v4
1919
# CHECK-ENCODING: [0x0b,0x64,0x4a,0x8a]
20-
# CHECK-ERROR: instruction requires the following: 'xtheadvdot' (T-Head Vector Extensions for Dot){{$}}
20+
# CHECK-ERROR: instruction requires the following: 'XTHeadVdot' (T-Head Vector Extensions for Dot){{$}}
2121
# CHECK-UNKNOWN: 8a4a640b <unknown>
2222

2323
th.vmaqau.vx v8, a0, v4, v0.t
2424
# CHECK-INST: th.vmaqau.vx v8, a0, v4, v0.t
2525
# CHECK-ENCODING: [0x0b,0x64,0x45,0x8c]
26-
# CHECK-ERROR: instruction requires the following: 'xtheadvdot' (T-Head Vector Extensions for Dot){{$}}
26+
# CHECK-ERROR: instruction requires the following: 'XTHeadVdot' (T-Head Vector Extensions for Dot){{$}}
2727
# CHECK-UNKNOWN: 8c45640b <unknown>
2828

2929
th.vmaqau.vx v8, a0, v4
3030
# CHECK-INST: th.vmaqau.vx v8, a0, v4
3131
# CHECK-ENCODING: [0x0b,0x64,0x45,0x8e]
32-
# CHECK-ERROR: instruction requires the following: 'xtheadvdot' (T-Head Vector Extensions for Dot){{$}}
32+
# CHECK-ERROR: instruction requires the following: 'XTHeadVdot' (T-Head Vector Extensions for Dot){{$}}
3333
# CHECK-UNKNOWN: 8e45640b <unknown>
3434

3535
th.vmaqa.vv v8, v20, v4, v0.t
3636
# CHECK-INST: th.vmaqa.vv v8, v20, v4, v0.t
3737
# CHECK-ENCODING: [0x0b,0x64,0x4a,0x80]
38-
# CHECK-ERROR: instruction requires the following: 'xtheadvdot' (T-Head Vector Extensions for Dot){{$}}
38+
# CHECK-ERROR: instruction requires the following: 'XTHeadVdot' (T-Head Vector Extensions for Dot){{$}}
3939
# CHECK-UNKNOWN: 804a640b <unknown>
4040

4141
th.vmaqa.vv v8, v20, v4
4242
# CHECK-INST: th.vmaqa.vv v8, v20, v4
4343
# CHECK-ENCODING: [0x0b,0x64,0x4a,0x82]
44-
# CHECK-ERROR: instruction requires the following: 'xtheadvdot' (T-Head Vector Extensions for Dot){{$}}
44+
# CHECK-ERROR: instruction requires the following: 'XTHeadVdot' (T-Head Vector Extensions for Dot){{$}}
4545
# CHECK-UNKNOWN: 824a640b <unknown>
4646

4747
th.vmaqa.vx v8, a0, v4, v0.t
4848
# CHECK-INST: th.vmaqa.vx v8, a0, v4, v0.t
4949
# CHECK-ENCODING: [0x0b,0x64,0x45,0x84]
50-
# CHECK-ERROR: instruction requires the following: 'xtheadvdot' (T-Head Vector Extensions for Dot){{$}}
50+
# CHECK-ERROR: instruction requires the following: 'XTHeadVdot' (T-Head Vector Extensions for Dot){{$}}
5151
# CHECK-UNKNOWN: 8445640b <unknown>
5252

5353
th.vmaqa.vx v8, a0, v4
5454
# CHECK-INST: th.vmaqa.vx v8, a0, v4
5555
# CHECK-ENCODING: [0x0b,0x64,0x45,0x86]
56-
# CHECK-ERROR: instruction requires the following: 'xtheadvdot' (T-Head Vector Extensions for Dot){{$}}
56+
# CHECK-ERROR: instruction requires the following: 'XTHeadVdot' (T-Head Vector Extensions for Dot){{$}}
5757
# CHECK-UNKNOWN: 8645640b <unknown>
5858

5959
th.vmaqasu.vv v8, v20, v4, v0.t
6060
# CHECK-INST: th.vmaqasu.vv v8, v20, v4, v0.t
6161
# CHECK-ENCODING: [0x0b,0x64,0x4a,0x90]
62-
# CHECK-ERROR: instruction requires the following: 'xtheadvdot' (T-Head Vector Extensions for Dot){{$}}
62+
# CHECK-ERROR: instruction requires the following: 'XTHeadVdot' (T-Head Vector Extensions for Dot){{$}}
6363
# CHECK-UNKNOWN: 904a640b <unknown>
6464

6565
th.vmaqasu.vv v8, v20, v4
6666
# CHECK-INST: th.vmaqasu.vv v8, v20, v4
6767
# CHECK-ENCODING: [0x0b,0x64,0x4a,0x92]
68-
# CHECK-ERROR: instruction requires the following: 'xtheadvdot' (T-Head Vector Extensions for Dot){{$}}
68+
# CHECK-ERROR: instruction requires the following: 'XTHeadVdot' (T-Head Vector Extensions for Dot){{$}}
6969
# CHECK-UNKNOWN: 924a640b <unknown>
7070

7171
th.vmaqasu.vx v8, a0, v4, v0.t
7272
# CHECK-INST: th.vmaqasu.vx v8, a0, v4, v0.t
7373
# CHECK-ENCODING: [0x0b,0x64,0x45,0x94]
74-
# CHECK-ERROR: instruction requires the following: 'xtheadvdot' (T-Head Vector Extensions for Dot){{$}}
74+
# CHECK-ERROR: instruction requires the following: 'XTHeadVdot' (T-Head Vector Extensions for Dot){{$}}
7575
# CHECK-UNKNOWN: 9445640b <unknown>
7676

7777
th.vmaqasu.vx v8, a0, v4
7878
# CHECK-INST: th.vmaqasu.vx v8, a0, v4
7979
# CHECK-ENCODING: [0x0b,0x64,0x45,0x96]
80-
# CHECK-ERROR: instruction requires the following: 'xtheadvdot' (T-Head Vector Extensions for Dot){{$}}
80+
# CHECK-ERROR: instruction requires the following: 'XTHeadVdot' (T-Head Vector Extensions for Dot){{$}}
8181
# CHECK-UNKNOWN: 9645640b <unknown>
8282

8383
th.vmaqaus.vx v8, a0, v4, v0.t
8484
# CHECK-INST: th.vmaqaus.vx v8, a0, v4, v0.t
8585
# CHECK-ENCODING: [0x0b,0x64,0x45,0x9c]
86-
# CHECK-ERROR: instruction requires the following: 'xtheadvdot' (T-Head Vector Extensions for Dot){{$}}
86+
# CHECK-ERROR: instruction requires the following: 'XTHeadVdot' (T-Head Vector Extensions for Dot){{$}}
8787
# CHECK-UNKNOWN: 9c45640b <unknown>
8888

8989
th.vmaqaus.vx v8, a0, v4
9090
# CHECK-INST: th.vmaqaus.vx v8, a0, v4
9191
# CHECK-ENCODING: [0x0b,0x64,0x45,0x9e]
92-
# CHECK-ERROR: instruction requires the following: 'xtheadvdot' (T-Head Vector Extensions for Dot){{$}}
92+
# CHECK-ERROR: instruction requires the following: 'XTHeadVdot' (T-Head Vector Extensions for Dot){{$}}
9393
# CHECK-UNKNOWN: 9e45640b <unknown>

0 commit comments

Comments
 (0)