Skip to content

Commit e98ae49

Browse files
committed
Address PR comments
1 parent 82fe20f commit e98ae49

File tree

6 files changed

+9
-9
lines changed

6 files changed

+9
-9
lines changed

clang/include/clang/Basic/DiagnosticSemaKinds.td

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5188,7 +5188,7 @@ def err_template_arg_not_object_or_func : Error<
51885188
def err_template_arg_not_pointer_to_member_form : Error<
51895189
"non-type template argument is not a pointer to member constant">;
51905190
def err_template_arg_member_ptr_base_derived_not_supported : Error<
5191-
"non-type template argument of a pointer to member type %1, that refers "
5191+
"non-type template argument of pointer-to-member type %1 that refers "
51925192
"to member %q0 of a different class is not supported yet">;
51935193
def err_template_arg_invalid : Error<
51945194
"non-type template argument '%0' is invalid">;
@@ -9916,8 +9916,8 @@ def warn_unsupported_lifetime_extension : Warning<
99169916
"lifetime extension of "
99179917
"%select{temporary|backing array of initializer list}0 created "
99189918
"by aggregate initialization using a default member initializer "
9919-
"is not supported; lifetime of %select{temporary|backing array}0 "
9920-
"will terminate at the end of the full-expression">, InGroup<Dangling>;
9919+
"is not yet supported; lifetime of %select{temporary|backing array}0 "
9920+
"will end at the end of the full-expression">, InGroup<Dangling>;
99219921

99229922
// For non-floating point, expressions of the form x == x or x != x
99239923
// should result in a warning, since these always evaluate to a constant.

clang/test/CXX/drs/dr16xx.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -472,7 +472,7 @@ namespace dr1696 { // dr1696: 7
472472
const A &a = A(); // #dr1696-D1-a
473473
};
474474
D1 d1 = {}; // #dr1696-d1
475-
// since-cxx14-warning@-1 {{lifetime extension of temporary created by aggregate initialization using a default member initializer is not supported; lifetime of temporary will terminate at the end of the full-expression}}
475+
// since-cxx14-warning@-1 {{lifetime extension of temporary created by aggregate initialization using a default member initializer is not yet supported; lifetime of temporary will end at the end of the full-expression}}
476476
// since-cxx14-note@#dr1696-D1-a {{initializing field 'a' with default member initializer}}
477477

478478
struct D2 {

clang/test/CXX/drs/dr18xx.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ namespace dr1815 { // dr1815: no
5656
// FIXME: needs codegen test
5757
struct A { int &&r = 0; }; // #dr1815-A
5858
A a = {};
59-
// since-cxx14-warning@-1 {{lifetime extension of temporary created by aggregate initialization using a default member initializer is not supported; lifetime of temporary will terminate at the end of the full-expression}} FIXME
59+
// since-cxx14-warning@-1 {{lifetime extension of temporary created by aggregate initialization using a default member initializer is not yet supported; lifetime of temporary will end at the end of the full-expression}} FIXME
6060
// since-cxx14-note@#dr1815-A {{initializing field 'r' with default member initializer}}
6161

6262
struct B { int &&r = 0; }; // #dr1815-B

clang/test/SemaCXX/constexpr-default-arg.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,6 @@ void test_default_arg2() {
3333
// Check that multiple CXXDefaultInitExprs don't cause an assertion failure.
3434
struct A { int &&r = 0; }; // expected-note 2{{default member initializer}}
3535
struct B { A x, y; };
36-
B b = {}; // expected-warning 2{{not supported}}
36+
B b = {}; // expected-warning 2{{lifetime extension of temporary created by aggregate initialization using a default member initializer is not yet supported}}
3737

3838
}

clang/test/SemaCXX/eval-crashes.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ namespace pr33140_2 {
2929
// temporaries.
3030
struct A { int &&r = 0; }; // expected-note 2{{initializing field 'r' with default member initializer}}
3131
struct B { A x, y; };
32-
B b = {}; // expected-warning 2{{not supported}}
32+
B b = {}; // expected-warning 2{{lifetime extension of temporary created by aggregate initialization using a default member initializer is not yet supported}}
3333
}
3434

3535
namespace pr33140_3 {

clang/test/SemaTemplate/temp_arg_nontype_cxx1z.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -205,9 +205,9 @@ namespace Auto {
205205

206206
struct Y : X {};
207207
void type_affects_identity(B<&X::n>) {}
208-
void type_affects_identity(B<(int Y::*)&X::n>) {} // FIXME: expected-error {{non-type template argument of a pointer to member type}}
208+
void type_affects_identity(B<(int Y::*)&X::n>) {} // FIXME: expected-error {{non-type template argument of pointer-to-member type}}
209209
void type_affects_identity(B<(const int X::*)&X::n>) {}
210-
void type_affects_identity(B<(const int Y::*)&X::n>) {} // FIXME: expected-error {{non-type template argument of a pointer to member type}}
210+
void type_affects_identity(B<(const int Y::*)&X::n>) {} // FIXME: expected-error {{non-type template argument of pointer-to-member type}}
211211

212212
// A case where we need to do auto-deduction, and check whether the
213213
// resulting dependent types match during partial ordering. These

0 commit comments

Comments
 (0)