Skip to content

Commit eabfda5

Browse files
committed
Fix comments per Matt
1 parent f338a84 commit eabfda5

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

llvm/include/llvm/CodeGen/ValueTypes.td

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -331,9 +331,11 @@ def i64x8 : ValueType<512, 231>; // 8 Consecutive GPRs (AArch64)
331331
def aarch64svcount
332332
: ValueType<16, 232>; // AArch64 predicate-as-counter
333333
def spirvbuiltin : ValueType<0, 233>; // SPIR-V's builtin type
334-
// AMDGPU buffer fat pointer, buffer rsrc + offset, rewritten before MIR translation
334+
// AMDGPU buffer fat pointer, buffer rsrc + offset, rewritten before MIR translation.
335+
// FIXME: Remove this and the getPointerType() override if MVT::i160 is added.
335336
def amdgpuBufferFatPointer : ValueType<160, 234>;
336-
// AMDGPU buffer strided pointer, buffer rsrc + index + offset, doesn't reach MIR
337+
// AMDGPU buffer strided pointer, buffer rsrc + index + offset, doesn't reach MIR.
338+
// FIXME: Remove this and the getPointerType() override if MVT::i82 is added.
337339
def amdgpuBufferStridedPointer : ValueType<192, 235>;
338340

339341
let isNormalValueType = false in {

llvm/lib/Target/AMDGPU/SIISelLowering.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -306,7 +306,7 @@ class SITargetLowering final : public AMDGPUTargetLowering {
306306
// have a MVT to prevent some analyses that query this function from breaking.
307307
// We use the custum MVT::amdgpuBufferFatPointer and
308308
// amdgpu::amdgpuBufferStridedPointer for this, though we use v8i32 for the
309-
// momyr type (which is probably unused).
309+
// memory type (which is probably unused).
310310
MVT getPointerTy(const DataLayout &DL, unsigned AS) const override;
311311
MVT getPointerMemTy(const DataLayout &DL, unsigned AS) const override;
312312

0 commit comments

Comments
 (0)