Skip to content

Commit eb446eb

Browse files
authored
[MLIR][BUILD] Fix Unicode build issue on Windows. (#112300)
This issue is from #77668. I encountered a build issue because it used Unicode. When I built MLIR on Windows with Visual Studio 2022, I faced a build failure. --------- Co-authored-by: Harrison Hao <[email protected]>
1 parent 7be4ab0 commit eb446eb

File tree

2 files changed

+9
-10
lines changed

2 files changed

+9
-10
lines changed

mlir/test/mlir-rewrite/simple.mlir

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@
44

55
func.func @two_dynamic_one_direct_shape(%arg0: tensor<?x4x?xf32>, %arg1: tensor<2x4x?xf32>) -> tensor<?x4x?xf32> {
66
// RENAME: "test.concat"({{.*}}) {bxis = 0 : i64}
7-
// RANGE: %{{.*}} = "test.concat"({{.*}}) {axis = 0 : i64} : (tensor<?x4x?xf32>, tensor<2x4x?xf32>) -> tensor<?x4x?xf32>
7+
// RANGE: <%{{.*}} = ["test.concat"]({{.*}}) {axis = 0 : i64} : (tensor<?x4x?xf32>, tensor<2x4x?xf32>) -> tensor<?x4x?xf32>>
88
%5 = "test.concat"(%arg0, %arg1) {axis = 0 : i64} : (tensor<?x4x?xf32>, tensor<2x4x?xf32>) -> tensor<?x4x?xf32>
99
return %5 : tensor<?x4x?xf32>
1010
}
11-

mlir/tools/mlir-rewrite/mlir-rewrite.cpp

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -320,25 +320,25 @@ LogicalResult markRanges(RewritePad &rewriteState, raw_ostream &os) {
320320
for (auto it : rewriteState.getOpDefs()) {
321321
auto [startOp, endOp] = getOpRange(it);
322322

323-
rewriteState.insertText(startOp, "");
324-
rewriteState.insertText(endOp, "");
323+
rewriteState.insertText(startOp, "<");
324+
rewriteState.insertText(endOp, ">");
325325

326326
auto nameRange = getOpNameRange(it);
327327

328328
if (isGeneric(it)) {
329-
rewriteState.insertText(nameRange.Start, "");
330-
rewriteState.insertText(nameRange.End, "");
329+
rewriteState.insertText(nameRange.Start, "[");
330+
rewriteState.insertText(nameRange.End, "]");
331331
} else {
332-
rewriteState.insertText(nameRange.Start, "");
333-
rewriteState.insertText(nameRange.End, "");
332+
rewriteState.insertText(nameRange.Start, "![");
333+
rewriteState.insertText(nameRange.End, "]!");
334334
}
335335
}
336336

337337
// Highlight all comment lines.
338338
// TODO: Could be replaced if this is kept in memory.
339339
for (auto commentLine : rewriteState.getSingleLineComments()) {
340-
rewriteState.insertText(commentLine.Start, "");
341-
rewriteState.insertText(commentLine.End, "");
340+
rewriteState.insertText(commentLine.Start, "{");
341+
rewriteState.insertText(commentLine.End, "}");
342342
}
343343

344344
return success();

0 commit comments

Comments
 (0)