[mlir] Use llvm::append_range (NFC) (#135722)

kazutakahirata · web-flow · commit eb7f51485e80 · 2025-04-14T22:22:04.000-07:00
diff --git a/mlir/include/mlir/Analysis/Presburger/GeneratingFunction.h b/mlir/include/mlir/Analysis/Presburger/GeneratingFunction.h
@@ -80,12 +80,10 @@ class GeneratingFunction {
     sumSigns.append(gf.signs);
 
     std::vector<ParamPoint> sumNumerators = numerators;
-    sumNumerators.insert(sumNumerators.end(), gf.numerators.begin(),
-                         gf.numerators.end());
+    llvm::append_range(sumNumerators, gf.numerators);
 
     std::vector<std::vector<Point>> sumDenominators = denominators;
-    sumDenominators.insert(sumDenominators.end(), gf.denominators.begin(),
-                           gf.denominators.end());
+    llvm::append_range(sumDenominators, gf.denominators);
     return GeneratingFunction(numParam, sumSigns, sumNumerators,
                               sumDenominators);
   }
diff --git a/mlir/lib/Analysis/Presburger/Barvinok.cpp b/mlir/lib/Analysis/Presburger/Barvinok.cpp
@@ -695,7 +695,7 @@ mlir::presburger::detail::computeNumTerms(const GeneratingFunction &gf) {
   // d_{ij} and substitute x accordingly.
   std::vector<Point> allDenominators;
   for (ArrayRef<Point> den : gf.getDenominators())
-    allDenominators.insert(allDenominators.end(), den.begin(), den.end());
+    llvm::append_range(allDenominators, den);
   Point mu = getNonOrthogonalVector(allDenominators);
 
   unsigned numParams = gf.getNumParams();
diff --git a/mlir/lib/Analysis/Presburger/QuasiPolynomial.cpp b/mlir/lib/Analysis/Presburger/QuasiPolynomial.cpp
@@ -48,7 +48,7 @@ QuasiPolynomial QuasiPolynomial::operator+(const QuasiPolynomial &x) const {
   SmallVector<Fraction> sumCoeffs = coefficients;
   sumCoeffs.append(x.coefficients);
   std::vector<std::vector<SmallVector<Fraction>>> sumAff = affine;
-  sumAff.insert(sumAff.end(), x.affine.begin(), x.affine.end());
+  llvm::append_range(sumAff, x.affine);
   return QuasiPolynomial(getNumInputs(), sumCoeffs, sumAff);
 }
 
@@ -79,8 +79,8 @@ QuasiPolynomial QuasiPolynomial::operator*(const QuasiPolynomial &x) const {
   for (const std::vector<SmallVector<Fraction>> &term : affine) {
     for (const std::vector<SmallVector<Fraction>> &xterm : x.affine) {
       product.clear();
-      product.insert(product.end(), term.begin(), term.end());
-      product.insert(product.end(), xterm.begin(), xterm.end());
+      llvm::append_range(product, term);
+      llvm::append_range(product, xterm);
       aff.emplace_back(product);
     }
   }
diff --git a/mlir/lib/Analysis/Presburger/Simplex.cpp b/mlir/lib/Analysis/Presburger/Simplex.cpp
@@ -1507,8 +1507,8 @@ Simplex Simplex::makeProduct(const Simplex &a, const Simplex &b) {
   auto concat = [](ArrayRef<Unknown> v, ArrayRef<Unknown> w) {
     SmallVector<Unknown, 8> result;
     result.reserve(v.size() + w.size());
-    result.insert(result.end(), v.begin(), v.end());
-    result.insert(result.end(), w.begin(), w.end());
+    llvm::append_range(result, v);
+    llvm::append_range(result, w);
     return result;
   };
   result.con = concat(a.con, b.con);
diff --git a/mlir/lib/Bytecode/Writer/BytecodeWriter.cpp b/mlir/lib/Bytecode/Writer/BytecodeWriter.cpp
@@ -568,9 +568,8 @@ class PropertiesSectionBuilder {
     std::vector<char> &newStorage = propertiesStorage.back();
     size_t propertiesSize = sizeScratch.size() + rawProperties.size();
     newStorage.reserve(propertiesSize);
-    newStorage.insert(newStorage.end(), sizeScratch.begin(), sizeScratch.end());
-    newStorage.insert(newStorage.end(), rawProperties.begin(),
-                      rawProperties.end());
+    llvm::append_range(newStorage, sizeScratch);
+    llvm::append_range(newStorage, rawProperties);
 
     // Try to de-duplicate the new serialized properties.
     // If the properties is a duplicate, pop it back from the storage.
diff --git a/mlir/lib/Dialect/Async/Transforms/AsyncToAsyncRuntime.cpp b/mlir/lib/Dialect/Async/Transforms/AsyncToAsyncRuntime.cpp
@@ -235,7 +235,7 @@ static CoroMachinery setupCoroMachinery(func::FuncOp func) {
   SmallVector<Value, 4> ret;
   if (retToken)
     ret.push_back(*retToken);
-  ret.insert(ret.end(), retValues.begin(), retValues.end());
+  llvm::append_range(ret, retValues);
   builder.create<func::ReturnOp>(ret);
 
   // `async.await` op lowering will create resume blocks for async
diff --git a/mlir/lib/Dialect/Linalg/Transforms/DataLayoutPropagation.cpp b/mlir/lib/Dialect/Linalg/Transforms/DataLayoutPropagation.cpp
@@ -676,11 +676,8 @@ bubbleUpPackOpThroughCollapseShape(tensor::CollapseShapeOp collapseOp,
   // new permutation after bubbling. This is because moving a collapsed dim is
   // equivalent to moving the associated source dims together.
   SmallVector<int64_t> newOuterDimsPerm;
-  for (auto outerPos : outerDimsPerm) {
-    newOuterDimsPerm.insert(newOuterDimsPerm.end(),
-                            reassocIndices[outerPos].begin(),
-                            reassocIndices[outerPos].end());
-  }
+  for (auto outerPos : outerDimsPerm)
+    llvm::append_range(newOuterDimsPerm, reassocIndices[outerPos]);
 
   auto emptyOp = linalg::PackOp::createDestinationTensor(
       rewriter, packOp.getLoc(), collapseOp.getSrc(), packOp.getMixedTiles(),
@@ -925,11 +922,8 @@ static LogicalResult pushDownUnPackOpThroughExpandShape(
   // new permutation after pushing. This is because moving a source dim is
   // equivalent to moving the associated expanded dims together.
   SmallVector<int64_t> newOuterDimsPerm;
-  for (auto outerPos : outerDimsPerm) {
-    newOuterDimsPerm.insert(newOuterDimsPerm.end(),
-                            reassocIndices[outerPos].begin(),
-                            reassocIndices[outerPos].end());
-  }
+  for (auto outerPos : outerDimsPerm)
+    llvm::append_range(newOuterDimsPerm, reassocIndices[outerPos]);
 
   SmallVector<ReassociationIndices> newReassocIndices = reassocIndices;
   // First apply the permutation on the reassociations of the outer dims.
diff --git a/mlir/lib/Dialect/MemRef/Utils/MemRefUtils.cpp b/mlir/lib/Dialect/MemRef/Utils/MemRefUtils.cpp
@@ -141,7 +141,7 @@ static bool resultIsNotRead(Operation *op, std::vector<Operation *> &uses) {
     }
     return false;
   }
-  uses.insert(uses.end(), opUses.begin(), opUses.end());
+  llvm::append_range(uses, opUses);
   return true;
 }
 
@@ -150,7 +150,7 @@ void eraseDeadAllocAndStores(RewriterBase &rewriter, Operation *parentOp) {
   parentOp->walk([&](memref::AllocOp op) {
     std::vector<Operation *> candidates;
     if (resultIsNotRead(op, candidates)) {
-      opToErase.insert(opToErase.end(), candidates.begin(), candidates.end());
+      llvm::append_range(opToErase, candidates);
       opToErase.push_back(op.getOperation());
     }
   });
diff --git a/mlir/lib/Dialect/SCF/IR/SCF.cpp b/mlir/lib/Dialect/SCF/IR/SCF.cpp
@@ -2017,8 +2017,7 @@ IfOp::inferReturnTypes(MLIRContext *ctx, std::optional<Location> loc,
   if (!yieldOp)
     return failure();
   TypeRange types = yieldOp.getOperandTypes();
-  inferredReturnTypes.insert(inferredReturnTypes.end(), types.begin(),
-                             types.end());
+  llvm::append_range(inferredReturnTypes, types);
   return success();
 }
 
diff --git a/mlir/lib/Dialect/Tosa/Transforms/TosaProfileCompliance.cpp b/mlir/lib/Dialect/Tosa/Transforms/TosaProfileCompliance.cpp
@@ -552,8 +552,7 @@ SmallVector<StringRef> TosaProfileCompliance::stringifyProfile(
 
   for (const auto &profiles : profileSet) {
     auto tempStrings = stringifyProfile<T>(profiles);
-    debugStrings.insert(debugStrings.end(), tempStrings.begin(),
-                        tempStrings.end());
+    llvm::append_range(debugStrings, tempStrings);
   }
 
   return debugStrings;
diff --git a/mlir/lib/Dialect/Vector/Transforms/VectorTransferSplitRewritePatterns.cpp b/mlir/lib/Dialect/Vector/Transforms/VectorTransferSplitRewritePatterns.cpp
@@ -258,8 +258,7 @@ createFullPartialLinalgCopy(RewriterBase &b, vector::TransferReadOp xferOp,
       [&](OpBuilder &b, Location loc) {
         Value res = castToCompatibleMemRefType(b, memref, compatibleMemRefType);
         scf::ValueVector viewAndIndices{res};
-        viewAndIndices.insert(viewAndIndices.end(), xferOp.getIndices().begin(),
-                              xferOp.getIndices().end());
+        llvm::append_range(viewAndIndices, xferOp.getIndices());
         b.create<scf::YieldOp>(loc, viewAndIndices);
       },
       [&](OpBuilder &b, Location loc) {
@@ -312,8 +311,7 @@ static scf::IfOp createFullPartialVectorTransferRead(
       [&](OpBuilder &b, Location loc) {
         Value res = castToCompatibleMemRefType(b, memref, compatibleMemRefType);
         scf::ValueVector viewAndIndices{res};
-        viewAndIndices.insert(viewAndIndices.end(), xferOp.getIndices().begin(),
-                              xferOp.getIndices().end());
+        llvm::append_range(viewAndIndices, xferOp.getIndices());
         b.create<scf::YieldOp>(loc, viewAndIndices);
       },
       [&](OpBuilder &b, Location loc) {
@@ -362,9 +360,7 @@ getLocationToWriteFullVec(RewriterBase &b, vector::TransferWriteOp xferOp,
             Value res =
                 castToCompatibleMemRefType(b, memref, compatibleMemRefType);
             scf::ValueVector viewAndIndices{res};
-            viewAndIndices.insert(viewAndIndices.end(),
-                                  xferOp.getIndices().begin(),
-                                  xferOp.getIndices().end());
+            llvm::append_range(viewAndIndices, xferOp.getIndices());
             b.create<scf::YieldOp>(loc, viewAndIndices);
           },
           [&](OpBuilder &b, Location loc) {
diff --git a/mlir/lib/Query/Query.cpp b/mlir/lib/Query/Query.cpp
@@ -54,12 +54,10 @@ static Operation *extractFunction(std::vector<Operation *> &ops,
       slice.push_back(op);
 
     // All results are returned by the extracted function.
-    outputTypes.insert(outputTypes.end(), op->getResults().getTypes().begin(),
-                       op->getResults().getTypes().end());
+    llvm::append_range(outputTypes, op->getResults().getTypes());
 
     // Track all values that need to be taken as input to function.
-    values.insert(values.end(), op->getOperands().begin(),
-                  op->getOperands().end());
+    llvm::append_range(values, op->getOperands());
   }
 
   // Create the function
diff --git a/mlir/lib/Tools/mlir-pdll-lsp-server/PDLLServer.cpp b/mlir/lib/Tools/mlir-pdll-lsp-server/PDLLServer.cpp
@@ -386,7 +386,7 @@ PDLDocument::PDLDocument(const lsp::URIForFile &uri, StringRef contents,
   llvm::SmallString<32> uriDirectory(uri.file());
   llvm::sys::path::remove_filename(uriDirectory);
   includeDirs.push_back(uriDirectory.str().str());
-  includeDirs.insert(includeDirs.end(), extraDirs.begin(), extraDirs.end());
+  llvm::append_range(includeDirs, extraDirs);
 
   sourceMgr.setIncludeDirs(includeDirs);
   sourceMgr.AddNewSourceBuffer(std::move(memBuffer), SMLoc());
diff --git a/mlir/lib/Tools/tblgen-lsp-server/TableGenServer.cpp b/mlir/lib/Tools/tblgen-lsp-server/TableGenServer.cpp
@@ -403,8 +403,7 @@ TableGenTextFile::TableGenTextFile(
   llvm::SmallString<32> uriDirectory(uri.file());
   llvm::sys::path::remove_filename(uriDirectory);
   includeDirs.push_back(uriDirectory.str().str());
-  includeDirs.insert(includeDirs.end(), extraIncludeDirs.begin(),
-                     extraIncludeDirs.end());
+  llvm::append_range(includeDirs, extraIncludeDirs);
 
   // Initialize the file.
   initialize(uri, version, diagnostics);

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ QuasiPolynomial QuasiPolynomial::operator+(const QuasiPolynomial &x) const {`
`48`	`48`	`SmallVector<Fraction> sumCoeffs = coefficients;`
`49`	`49`	`sumCoeffs.append(x.coefficients);`
`50`	`50`	`std::vector<std::vector<SmallVector<Fraction>>> sumAff = affine;`
`51`		`- sumAff.insert(sumAff.end(), x.affine.begin(), x.affine.end());`
	`51`	`+ llvm::append_range(sumAff, x.affine);`
`52`	`52`	`return QuasiPolynomial(getNumInputs(), sumCoeffs, sumAff);`
`53`	`53`	`}`
`54`	`54`
`@@ -79,8 +79,8 @@ QuasiPolynomial QuasiPolynomial::operator*(const QuasiPolynomial &x) const {`
`79`	`79`	`for (const std::vector<SmallVector<Fraction>> &term : affine) {`
`80`	`80`	`for (const std::vector<SmallVector<Fraction>> &xterm : x.affine) {`
`81`	`81`	`product.clear();`
`82`		`- product.insert(product.end(), term.begin(), term.end());`
`83`		`- product.insert(product.end(), xterm.begin(), xterm.end());`
	`82`	`+ llvm::append_range(product, term);`
	`83`	`+ llvm::append_range(product, xterm);`
`84`	`84`	`aff.emplace_back(product);`
`85`	`85`	`}`
`86`	`86`	`}`
Original file line number	Diff line number	Diff line change
`@@ -141,7 +141,7 @@ static bool resultIsNotRead(Operation op, std::vector<Operation > &uses) {`
`141`	`141`	`}`
`142`	`142`	`return false;`
`143`	`143`	`}`
`144`		`- uses.insert(uses.end(), opUses.begin(), opUses.end());`
	`144`	`+ llvm::append_range(uses, opUses);`
`145`	`145`	`return true;`
`146`	`146`	`}`
`147`	`147`
`@@ -150,7 +150,7 @@ void eraseDeadAllocAndStores(RewriterBase &rewriter, Operation *parentOp) {`
`150`	`150`	`parentOp->walk([&](memref::AllocOp op) {`
`151`	`151`	`std::vector<Operation *> candidates;`
`152`	`152`	`if (resultIsNotRead(op, candidates)) {`
`153`		`- opToErase.insert(opToErase.end(), candidates.begin(), candidates.end());`
	`153`	`+ llvm::append_range(opToErase, candidates);`
`154`	`154`	`opToErase.push_back(op.getOperation());`
`155`	`155`	`}`
`156`	`156`	`});`
Original file line number	Diff line number	Diff line change
`@@ -2017,8 +2017,7 @@ IfOp::inferReturnTypes(MLIRContext *ctx, std::optional<Location> loc,`
`2017`	`2017`	`if (!yieldOp)`
`2018`	`2018`	`return failure();`
`2019`	`2019`	`TypeRange types = yieldOp.getOperandTypes();`
`2020`		`- inferredReturnTypes.insert(inferredReturnTypes.end(), types.begin(),`
`2021`		`- types.end());`
	`2020`	`+ llvm::append_range(inferredReturnTypes, types);`
`2022`	`2021`	`return success();`
`2023`	`2022`	`}`
`2024`	`2023`
Original file line number	Diff line number	Diff line change
`@@ -552,8 +552,7 @@ SmallVector<StringRef> TosaProfileCompliance::stringifyProfile(`
`552`	`552`
`553`	`553`	`for (const auto &profiles : profileSet) {`
`554`	`554`	`auto tempStrings = stringifyProfile<T>(profiles);`
`555`		`- debugStrings.insert(debugStrings.end(), tempStrings.begin(),`
`556`		`- tempStrings.end());`
	`555`	`+ llvm::append_range(debugStrings, tempStrings);`
`557`	`556`	`}`
`558`	`557`
`559`	`558`	`return debugStrings;`