Skip to content

Commit ec7062d

Browse files
authored
[clangd] Add metric for rename decl kind (#83867)
This will give us insight into what users are renaming in practice - for instance, try to gauge the impact of the ObjC rename support.
1 parent da63746 commit ec7062d

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

clang-tools-extra/clangd/refactor/Rename.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1062,6 +1062,10 @@ llvm::Expected<RenameResult> rename(const RenameInputs &RInputs) {
10621062
return makeError(ReasonToReject::AmbiguousSymbol);
10631063

10641064
const auto &RenameDecl = **DeclsUnderCursor.begin();
1065+
static constexpr trace::Metric RenameTriggerCounter(
1066+
"rename_trigger_count", trace::Metric::Counter, "decl_kind");
1067+
RenameTriggerCounter.record(1, RenameDecl.getDeclKindName());
1068+
10651069
std::string Placeholder = getName(RenameDecl);
10661070
auto Invalid = checkName(RenameDecl, RInputs.NewName, Placeholder);
10671071
if (Invalid)

0 commit comments

Comments
 (0)