Skip to content

Commit ece2c25

Browse files
authored
[LLDB][Test] Fix the test case of listing verbose break info on Windows (#85200)
I noticed a failure of [running LLDB test suites on Windows AArch64](https://lab.llvm.org/buildbot/#/builders/219/builds/9849). The failed test case is about checking output of command `breakpoint list -v -L c++`, and an mismatch on the demangled name of a function occurred. The test case expects `ns::func(void)`, but on Windows it is `int ns::func(void)`. It results from the different mangling scheme used by MSVC, and the comparison is as follows: | Scheme | Mangled | Demangled (fully) | Note | | --- | --- | --- | --- | | MSVC | `?func@ns@@YAHXZ` | `int __cdecl ns::func(void)` | [Godbolt](https://godbolt.org/z/5ns8c7xW3) (I have no available Windows device) | | Itanium | `_ZN2ns4funcEv` | `ns::func()` | | According to the current use of MSVC demangling, https://github.com/llvm/llvm-project/blob/8f68022f8e6e54d1aeae4ed301f5a015963089b7/lldb/source/Core/Mangled.cpp#L128-L143 the `__cdecl` specifier is not part of the name. However, the function's parameter types should be present as ` llvm::MSDF_NoVariableType` [does not affect a symbol for functions](https://github.com/llvm/llvm-project/blob/8f68022f8e6e54d1aeae4ed301f5a015963089b7/llvm/lib/Demangle/MicrosoftDemangleNodes.cpp#L417-L453). Therefore, it is inappropriate to assume the demangled name are the same on all platforms. Instead of tweaking the existing code of demangling to get the same (demangled) name, I think it is more reasonable to modify the test case.
1 parent 8f68022 commit ece2c25

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

lldb/test/API/functionalities/breakpoint/breakpoint_options/TestBreakpointOptions.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,10 @@ def breakpoint_options_language_test(self):
9595
self.expect(
9696
"breakpoint list -v",
9797
"Verbose breakpoint list contains mangled names",
98+
# The demangled function name is system-dependent, e.g.
99+
# 'int ns::func(void)' on Windows and 'ns::func()' on Linux.
98100
substrs=[
99-
"function = ns::func",
101+
f"function = {function.GetName()}",
100102
f"mangled function = {function.GetMangledName()}",
101103
],
102104
)

0 commit comments

Comments
 (0)