Skip to content

Commit eea232d

Browse files
committed
[clang][tools] Remove path separator assumption
After 98e6deb the 'HeadersForSymbolTest.IWYUTransitiveExportWithPrivate' test in 'ClangIncludeCleanerTest' started failing. This is most likely because `FileEntryRef::getName()` now starts with ".\" on Windows, whereas `FileEntry::getName()` did not. This commit fixes assumption of forward slash separators.
1 parent 60c0d30 commit eea232d

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

clang-tools-extra/include-cleaner/lib/FindHeaders.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,7 @@ llvm::SmallVector<Header> ranked(llvm::SmallVector<Hinted<Header>> Headers) {
5050
// name.
5151
llvm::StringRef basename(llvm::StringRef Header) {
5252
Header = Header.trim("<>\"");
53-
if (auto LastSlash = Header.rfind('/'); LastSlash != Header.npos)
54-
Header = Header.drop_front(LastSlash + 1);
53+
Header = llvm::sys::path::filename(Header);
5554
// Drop everything after first `.` (dot).
5655
// foo.h -> foo
5756
// foo.cu.h -> foo

0 commit comments

Comments
 (0)