Add MFPropsModifier and apply suggestions

Author: optimisan

llvm/lib/Target/AMDGPU/GCNDPPCombine.cpp

@@ -754,9 +754,9 @@ bool GCNDPPCombine::combineDPPMov(MachineInstr &MovMI) const {
 }
 
 bool GCNDPPCombineLegacy::runOnMachineFunction(MachineFunction &MF) {
-  if (skipFunction(MF.getFunction())) {
+  if (skipFunction(MF.getFunction()))
     return false;
-  }
+
   return GCNDPPCombine().run(MF);
 }
 
@@ -795,10 +795,15 @@ bool GCNDPPCombine::run(MachineFunction &MF) {
 
 PreservedAnalyses GCNDPPCombinePass::run(MachineFunction &MF,
                                          MachineFunctionAnalysisManager &) {
+  if (MF.getFunction().hasOptNone())
+    return PreservedAnalyses::all();
+
+  MFPropsModifier _(*this, MF);
+
   bool Changed = GCNDPPCombine().run(MF);
-  if (!Changed) {
+  if (!Changed)
     return PreservedAnalyses::all();
-  }
+
   auto PA = getMachineFunctionPassPreservedAnalyses();
   PA.preserveSet<CFGAnalyses>();
   return PA;

llvm/lib/Target/AMDGPU/GCNDPPCombine.h

@@ -25,4 +25,4 @@ class GCNDPPCombinePass : public PassInfoMixin<GCNDPPCombinePass> {
 
 } // end namespace llvm
 
-#endif
+#endif // LLVM_LIB_TARGET_AMDGPU_GCNDPPCOMBINE_H