Skip to content

Commit ef6014e

Browse files
authored
[MLIR][LaunchFuncToLLVM] Remove typed pointer support (#70840)
This commit removes the typed pointer support from the LaunchFunc's lowering to LLVM dialect. Typed pointers have been deprecated for a while now and it's planned to soon remove them from the LLVM dialect. Related PSA: https://discourse.llvm.org/t/psa-removal-of-typed-pointers-from-the-llvm-dialect/74502
1 parent a78f5c0 commit ef6014e

File tree

2 files changed

+0
-7
lines changed

2 files changed

+0
-7
lines changed

mlir/include/mlir/Conversion/Passes.td

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -472,12 +472,6 @@ def LowerHostCodeToLLVMPass : Pass<"lower-host-to-llvm", "ModuleOp"> {
472472
dialect, emitting C wrappers.
473473
}];
474474

475-
let options = [
476-
Option<"useOpaquePointers", "use-opaque-pointers", "bool",
477-
/*default=*/"true", "Generate LLVM IR using opaque pointers "
478-
"instead of typed pointers">
479-
];
480-
481475
let dependentDialects = ["LLVM::LLVMDialect"];
482476
}
483477

mlir/lib/Conversion/SPIRVToLLVM/ConvertLaunchFuncToLLVMCalls.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -298,7 +298,6 @@ class LowerHostCodeToLLVM
298298

299299
// Specify options to lower to LLVM and pull in the conversion patterns.
300300
LowerToLLVMOptions options(module.getContext());
301-
options.useOpaquePointers = useOpaquePointers;
302301

303302
auto *context = module.getContext();
304303
RewritePatternSet patterns(context);

0 commit comments

Comments
 (0)