Skip to content

Commit ef848fd

Browse files
committed
removeFile() -> overwriteFile()
1 parent 1715b2d commit ef848fd

File tree

1 file changed

+15
-11
lines changed

1 file changed

+15
-11
lines changed

lldb/test/API/commands/settings/use_source_cache/TestUseSourceCache.py

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,9 @@ def test_set_use_source_cache_false(self):
1717
"""Test that after 'set use-source-cache false', files are not locked."""
1818
self.set_use_source_cache_and_test(False)
1919

20+
@skipIf(hostoslist=no_match(["windows"]))
2021
def test_set_use_source_cache_true(self):
21-
"""Test that after 'set use-source-cache false', files are locked."""
22+
"""Test that after 'set use-source-cache true', files are locked."""
2223
self.set_use_source_cache_and_test(True)
2324

2425
def set_use_source_cache_and_test(self, is_cache_enabled):
@@ -41,25 +42,28 @@ def set_use_source_cache_and_test(self, is_cache_enabled):
4142
self, "calc"
4243
)
4344

44-
# Ensure that the source file is loaded.
45-
self.expect("step", patterns=["-> .+ int x4 ="])
45+
# Show the source file contents to make sure LLDB loads src file.
46+
self.runCmd("source list")
4647

47-
# Try deleting the source file.
48-
is_file_removed = self.removeFile(src)
48+
# Try overwriting the source file.
49+
is_file_overwritten = self.overwriteFile(src)
4950

5051
if is_cache_enabled:
51-
# Regardless of whether the file is removed, its contents should be displayed.
52-
self.expect("step", patterns=["-> .+ int x5 ="])
52+
self.assertFalse(
53+
is_file_overwritten, "Source cache is enabled, but writing to file succeeded"
54+
)
5355

5456
if not is_cache_enabled:
5557
self.assertTrue(
56-
is_file_removed, "Source cache is disabled, but delete file failed"
58+
is_file_overwritten, "Source cache is disabled, but writing to file failed"
5759
)
5860

59-
def removeFile(self, src):
60-
"""Remove file and return true iff file was successfully removed."""
61+
def overwriteFile(self, src):
62+
"""Write to file and return true iff file was successfully written."""
6163
try:
62-
os.remove(src)
64+
f = open(src, "w")
65+
f.writelines(["// hello world\n"])
66+
f.close()
6367
return True
6468
except Exception:
6569
return False

0 commit comments

Comments
 (0)