Fix small remarks

Author: brunodf-snps

llvm/include/llvm/Analysis/AliasSetTracker.h

@@ -54,7 +54,7 @@ class AliasSet : public ilist_node<AliasSet> {
   AliasSet *Forward = nullptr;
 
   /// Memory locations in this alias set.
-  std::vector<MemoryLocation> MemoryLocs;
+  SmallVector<MemoryLocation, 0> MemoryLocs;
 
   /// All instructions without a specific address in this alias set.
   std::vector<AssertingVH<Instruction>> UnknownInsts;
@@ -119,7 +119,7 @@ class AliasSet : public ilist_node<AliasSet> {
 
   // Alias Set iteration - Allow access to all of the memory locations which are
   // part of this alias set.
-  using iterator = std::vector<MemoryLocation>::const_iterator;
+  using iterator = SmallVectorImpl<MemoryLocation>::const_iterator;
   iterator begin() const { return MemoryLocs.begin(); }
   iterator end() const { return MemoryLocs.end(); }
 

llvm/lib/Analysis/AliasSetTracker.cpp

@@ -11,6 +11,7 @@
 //===----------------------------------------------------------------------===//
 
 #include "llvm/Analysis/AliasSetTracker.h"
+#include "llvm/ADT/SetVector.h"
 #include "llvm/ADT/StringExtras.h"
 #include "llvm/Analysis/AliasAnalysis.h"
 #include "llvm/Analysis/GuardUtils.h"
@@ -201,23 +202,10 @@ ModRefInfo AliasSet::aliasesUnknownInst(const Instruction *Inst,
 }
 
 AliasSet::PointerVector AliasSet::getPointers() const {
-  // To deduplicate pointer values, use a linear scan if the number of elements
-  // is small, or a set if large. This is the same idea as SmallSetVector. In
-  // addition, we can allocate space for the result vector upfront.
-  PointerVector Result;
-  if (MemoryLocs.size() <= Result.capacity()) {
-    for (const MemoryLocation &MemLoc : MemoryLocs)
-      if (llvm::find(Result, MemLoc.Ptr) == Result.end())
-        Result.push_back(MemLoc.Ptr);
-  } else {
-    Result.reserve(MemoryLocs.size());
-    DenseSet<const Value *> Seen;
-    Seen.reserve(MemoryLocs.size());
-    for (const MemoryLocation &MemLoc : MemoryLocs)
-      if (Seen.insert(MemLoc.Ptr).second)
-        Result.push_back(MemLoc.Ptr);
-  }
-  return Result;
+  SmallSetVector<const Value *, 8> Pointers;
+  for (const MemoryLocation &MemLoc : MemoryLocs)
+    Pointers.insert(MemLoc.Ptr);
+  return Pointers.takeVector();
 }
 
 void AliasSetTracker::clear() {

llvm/lib/Analysis/LoopAccessAnalysis.cpp

@@ -1143,7 +1143,7 @@ bool AccessAnalysis::canCheckPtrAtRT(RuntimePointerChecking &RtCheck,
         (NumWritePtrChecks == 1 && NumReadPtrChecks == 0)) {
       assert((ASPointers.size() <= 1 ||
               all_of(ASPointers,
-                     [this](auto Ptr) {
+                     [this](const Value *Ptr) {
                        MemAccessInfo AccessWrite(const_cast<Value *>(Ptr),
                                                  true);
                        return DepCands.findValue(AccessWrite) == DepCands.end();