Skip to content

Commit efd45d8

Browse files
committed
expandFMINIMUMNUM_FMAXIMUMNUM: Quiet is not needed for NaN vs NaN
New LangRef doesn't requires quieting for NaN vs NaN, aka the result may be sNaN for sNaN vs NaN. See: #139228
1 parent 4583076 commit efd45d8

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8692,11 +8692,6 @@ SDValue TargetLowering::expandFMINIMUMNUM_FMAXIMUMNUM(SDNode *Node,
86928692

86938693
SDValue MinMax =
86948694
DAG.getSelectCC(DL, LHS, RHS, LHS, RHS, IsMax ? ISD::SETGT : ISD::SETLT);
8695-
// If MinMax is NaN, let's quiet it.
8696-
if (!Flags.hasNoNaNs() && !DAG.isKnownNeverNaN(LHS) &&
8697-
!DAG.isKnownNeverNaN(RHS)) {
8698-
MinMax = DAG.getNode(ISD::FCANONICALIZE, DL, VT, MinMax, Flags);
8699-
}
87008695

87018696
// Fixup signed zero behavior.
87028697
if (Options.NoSignedZerosFPMath || Flags.hasNoSignedZeros() ||

0 commit comments

Comments
 (0)