Skip to content

Commit f0f1d26

Browse files
Revert "TLS loads opimization (hoist)"
This reverts commit c310143.
1 parent 5a47d48 commit f0f1d26

File tree

20 files changed

+11
-1106
lines changed

20 files changed

+11
-1106
lines changed

llvm/docs/LangRef.rst

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2495,11 +2495,6 @@ example:
24952495
function with a tail call. The prototype of a thunk should not be used for
24962496
optimization purposes. The caller is expected to cast the thunk prototype to
24972497
match the thunk target prototype.
2498-
2499-
``"tls-load-hoist"``
2500-
This attribute indicates that the function will try to reduce redundant
2501-
tls address calculation by hoisting tls variable.
2502-
25032498
``uwtable[(sync|async)]``
25042499
This attribute indicates that the ABI being targeted requires that
25052500
an unwind table entry be produced for this function even if we can

llvm/include/llvm/InitializePasses.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -303,7 +303,6 @@ void initializeTailDuplicatePass(PassRegistry &);
303303
void initializeTargetLibraryInfoWrapperPassPass(PassRegistry &);
304304
void initializeTargetPassConfigPass(PassRegistry &);
305305
void initializeTargetTransformInfoWrapperPassPass(PassRegistry &);
306-
void initializeTLSVariableHoistLegacyPassPass(PassRegistry &);
307306
void initializeTwoAddressInstructionLegacyPassPass(PassRegistry &);
308307
void initializeTypeBasedAAWrapperPassPass(PassRegistry &);
309308
void initializeTypePromotionLegacyPass(PassRegistry &);

llvm/include/llvm/LinkAllPasses.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,6 @@ struct ForcePassLinking {
112112
(void)llvm::createSROAPass();
113113
(void)llvm::createSingleLoopExtractorPass();
114114
(void)llvm::createTailCallEliminationPass();
115-
(void)llvm::createTLSVariableHoistPass();
116115
(void)llvm::createConstantHoistingPass();
117116
(void)llvm::createCodeGenPrepareLegacyPass();
118117
(void)llvm::createPostInlineEntryExitInstrumenterPass();

llvm/include/llvm/Transforms/Scalar.h

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -153,9 +153,16 @@ extern char &InferAddressSpacesID;
153153

154154
//===----------------------------------------------------------------------===//
155155
//
156-
// TLSVariableHoist - This pass reduce duplicated TLS address call.
156+
// LowerExpectIntrinsics - Removes llvm.expect intrinsics and creates
157+
// "block_weights" metadata.
158+
FunctionPass *createLowerExpectIntrinsicPass();
159+
160+
//===----------------------------------------------------------------------===//
161+
//
162+
// LowerConstantIntrinsicss - Expand any remaining llvm.objectsize and
163+
// llvm.is.constant intrinsic calls, even for the unknown cases.
157164
//
158-
FunctionPass *createTLSVariableHoistPass();
165+
FunctionPass *createLowerConstantIntrinsicsPass();
159166

160167
//===----------------------------------------------------------------------===//
161168
//

llvm/include/llvm/Transforms/Scalar/TLSVariableHoist.h

Lines changed: 0 additions & 131 deletions
This file was deleted.

llvm/lib/CodeGen/TargetPassConfig.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -881,9 +881,6 @@ void TargetPassConfig::addIRPasses() {
881881
if (!DisableExpandReductions)
882882
addPass(createExpandReductionsPass());
883883

884-
if (getOptLevel() != CodeGenOptLevel::None)
885-
addPass(createTLSVariableHoistPass());
886-
887884
// Convert conditional moves to conditional jumps when profitable.
888885
if (getOptLevel() != CodeGenOptLevel::None && !DisableSelectOptimize)
889886
addPass(createSelectOptimizePass());

llvm/lib/Passes/PassBuilder.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,6 @@
287287
#include "llvm/Transforms/Scalar/SpeculativeExecution.h"
288288
#include "llvm/Transforms/Scalar/StraightLineStrengthReduce.h"
289289
#include "llvm/Transforms/Scalar/StructurizeCFG.h"
290-
#include "llvm/Transforms/Scalar/TLSVariableHoist.h"
291290
#include "llvm/Transforms/Scalar/TailRecursionElimination.h"
292291
#include "llvm/Transforms/Scalar/WarnMissedTransforms.h"
293292
#include "llvm/Transforms/Utils/AddDiscriminators.h"

llvm/lib/Passes/PassRegistry.def

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -468,7 +468,6 @@ FUNCTION_PASS("slsr", StraightLineStrengthReducePass())
468468
FUNCTION_PASS("stack-protector", StackProtectorPass(TM))
469469
FUNCTION_PASS("strip-gc-relocates", StripGCRelocates())
470470
FUNCTION_PASS("tailcallelim", TailCallElimPass())
471-
FUNCTION_PASS("tlshoist", TLSVariableHoistPass())
472471
FUNCTION_PASS("transform-warning", WarnMissedTransformationsPass())
473472
FUNCTION_PASS("trigger-crash-function", TriggerCrashFunctionPass())
474473
FUNCTION_PASS("trigger-verifier-error", TriggerVerifierErrorPass())

llvm/lib/Transforms/Scalar/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,6 @@ add_llvm_component_library(LLVMScalarOpts
7878
StraightLineStrengthReduce.cpp
7979
StructurizeCFG.cpp
8080
TailRecursionElimination.cpp
81-
TLSVariableHoist.cpp
8281
WarnMissedTransforms.cpp
8382

8483
ADDITIONAL_HEADER_DIRS

llvm/lib/Transforms/Scalar/Scalar.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ void llvm::initializeScalarOpts(PassRegistry &Registry) {
4444
initializeStructurizeCFGLegacyPassPass(Registry);
4545
initializeSinkingLegacyPassPass(Registry);
4646
initializeTailCallElimPass(Registry);
47-
initializeTLSVariableHoistLegacyPassPass(Registry);
4847
initializeSeparateConstOffsetFromGEPLegacyPassPass(Registry);
4948
initializeSpeculativeExecutionLegacyPassPass(Registry);
5049
initializeStraightLineStrengthReduceLegacyPassPass(Registry);

0 commit comments

Comments
 (0)