Fix MSVC "not all control paths return a value" warning. NFC.

RKSimon · RKSimon · commit f139387fb6e7 · 2024-04-08T14:31:46.000+01:00
diff --git a/clang/lib/InstallAPI/DiagnosticBuilderWrappers.cpp b/clang/lib/InstallAPI/DiagnosticBuilderWrappers.cpp
@@ -81,8 +81,9 @@ const DiagnosticBuilder &operator<<(const DiagnosticBuilder &DB,
     return DB;
   case FileType::Invalid:
   case FileType::All:
-    llvm_unreachable("Unexpected file type for diagnostics.");
+    break;
   }
+  llvm_unreachable("Unexpected file type for diagnostics.");
 }
 
 const DiagnosticBuilder &operator<<(const DiagnosticBuilder &DB,

Original file line number	Diff line number	Diff line change
`@@ -81,8 +81,9 @@ const DiagnosticBuilder &operator<<(const DiagnosticBuilder &DB,`
`81`	`81`	`return DB;`
`82`	`82`	`case FileType::Invalid:`
`83`	`83`	`case FileType::All:`
`84`		`- llvm_unreachable("Unexpected file type for diagnostics.");`
	`84`	`+ break;`
`85`	`85`	`}`
	`86`	`+ llvm_unreachable("Unexpected file type for diagnostics.");`
`86`	`87`	`}`
`87`	`88`
`88`	`89`	`const DiagnosticBuilder &operator<<(const DiagnosticBuilder &DB,`