Skip to content

Commit f14224d

Browse files
authored
[RISCV] Rename schedule classes for vmv.s.x, vmv.x.s, vfmv.s.f, and vfmv.f.s [nfc] (#84563)
The prior naming scheme is incredibly hard to make sense out of. I suspect the usage was actually backwards from intent - though that didn't matter for any in tree schedule model.
1 parent 2953d9c commit f14224d

File tree

4 files changed

+39
-39
lines changed

4 files changed

+39
-39
lines changed

llvm/lib/Target/RISCV/RISCVInstrInfoV.td

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1637,11 +1637,11 @@ def VID_V : RVInstV<0b010100, 0b10001, OPMVV, (outs VR:$vd),
16371637
let vm = 1, RVVConstraint = NoConstraint in {
16381638
def VMV_X_S : RVInstV<0b010000, 0b00000, OPMVV, (outs GPR:$vd),
16391639
(ins VR:$vs2), "vmv.x.s", "$vd, $vs2">,
1640-
Sched<[WriteVIMovVX, ReadVIMovVX]>;
1640+
Sched<[WriteVMovXS, ReadVMovXS]>;
16411641
let Constraints = "$vd = $vd_wb" in
16421642
def VMV_S_X : RVInstV2<0b010000, 0b00000, OPMVX, (outs VR:$vd_wb),
16431643
(ins VR:$vd, GPR:$rs1), "vmv.s.x", "$vd, $rs1">,
1644-
Sched<[WriteVIMovXV, ReadVIMovXV, ReadVIMovXX]>;
1644+
Sched<[WriteVMovSX, ReadVMovSX_V, ReadVMovSX_X]>;
16451645
}
16461646

16471647
} // hasSideEffects = 0, mayLoad = 0, mayStore = 0
@@ -1655,11 +1655,11 @@ let hasSideEffects = 0, mayLoad = 0, mayStore = 0, vm = 1,
16551655
// Floating-Point Scalar Move Instructions
16561656
def VFMV_F_S : RVInstV<0b010000, 0b00000, OPFVV, (outs FPR32:$vd),
16571657
(ins VR:$vs2), "vfmv.f.s", "$vd, $vs2">,
1658-
Sched<[WriteVFMovVF, ReadVFMovVF]>;
1658+
Sched<[WriteVMovFS, ReadVMovFS]>;
16591659
let Constraints = "$vd = $vd_wb" in
16601660
def VFMV_S_F : RVInstV2<0b010000, 0b00000, OPFVF, (outs VR:$vd_wb),
16611661
(ins VR:$vd, FPR32:$rs1), "vfmv.s.f", "$vd, $rs1">,
1662-
Sched<[WriteVFMovFV, ReadVFMovFV, ReadVFMovFX]>;
1662+
Sched<[WriteVMovSF, ReadVMovSF_V, ReadVMovSF_F]>;
16631663

16641664
} // hasSideEffects = 0, mayLoad = 0, mayStore = 0, vm = 1
16651665

llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6767,14 +6767,14 @@ let mayLoad = 0, mayStore = 0, hasSideEffects = 0 in {
67676767
let HasSEWOp = 1, BaseInstr = VMV_X_S in
67686768
def PseudoVMV_X_S:
67696769
Pseudo<(outs GPR:$rd), (ins VR:$rs2, ixlenimm:$sew), []>,
6770-
Sched<[WriteVIMovVX, ReadVIMovVX]>,
6770+
Sched<[WriteVMovXS, ReadVMovXS]>,
67716771
RISCVVPseudo;
67726772
let HasVLOp = 1, HasSEWOp = 1, BaseInstr = VMV_S_X,
67736773
Constraints = "$rd = $rs1" in
67746774
def PseudoVMV_S_X: Pseudo<(outs VR:$rd),
67756775
(ins VR:$rs1, GPR:$rs2, AVL:$vl, ixlenimm:$sew),
67766776
[]>,
6777-
Sched<[WriteVIMovXV, ReadVIMovXV, ReadVIMovXX]>,
6777+
Sched<[WriteVMovSX, ReadVMovSX_V, ReadVMovSX_X]>,
67786778
RISCVVPseudo;
67796779
}
67806780
} // Predicates = [HasVInstructions]
@@ -6793,7 +6793,7 @@ let mayLoad = 0, mayStore = 0, hasSideEffects = 0 in {
67936793
def "PseudoVFMV_" # f.FX # "_S_" # mx :
67946794
Pseudo<(outs f.fprclass:$rd),
67956795
(ins m.vrclass:$rs2, ixlenimm:$sew), []>,
6796-
Sched<[WriteVFMovVF, ReadVFMovVF]>,
6796+
Sched<[WriteVMovFS, ReadVMovFS]>,
67976797
RISCVVPseudo;
67986798
let HasVLOp = 1, HasSEWOp = 1, BaseInstr = VFMV_S_F,
67996799
Constraints = "$rd = $rs1" in
@@ -6802,7 +6802,7 @@ let mayLoad = 0, mayStore = 0, hasSideEffects = 0 in {
68026802
(ins m.vrclass:$rs1, f.fprclass:$rs2,
68036803
AVL:$vl, ixlenimm:$sew),
68046804
[]>,
6805-
Sched<[WriteVFMovFV, ReadVFMovFV, ReadVFMovFX]>,
6805+
Sched<[WriteVMovSF, ReadVMovSF_V, ReadVMovSF_F]>,
68066806
RISCVVPseudo;
68076807
}
68086808
}

llvm/lib/Target/RISCV/RISCVSchedSiFive7.td

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -887,10 +887,10 @@ foreach mx = SchedMxList in {
887887

888888
// 16. Vector Permutation Instructions
889889
let Latency = 4, AcquireAtCycles = [0, 1], ReleaseAtCycles = [1, !add(1, 1)] in {
890-
def : WriteRes<WriteVIMovVX, [SiFive7VCQ, SiFive7VA]>;
891-
def : WriteRes<WriteVIMovXV, [SiFive7VCQ, SiFive7VA]>;
892-
def : WriteRes<WriteVFMovVF, [SiFive7VCQ, SiFive7VA]>;
893-
def : WriteRes<WriteVFMovFV, [SiFive7VCQ, SiFive7VA]>;
890+
def : WriteRes<WriteVMovSX, [SiFive7VCQ, SiFive7VA]>;
891+
def : WriteRes<WriteVMovXS, [SiFive7VCQ, SiFive7VA]>;
892+
def : WriteRes<WriteVMovSF, [SiFive7VCQ, SiFive7VA]>;
893+
def : WriteRes<WriteVMovFS, [SiFive7VCQ, SiFive7VA]>;
894894
}
895895
foreach mx = SchedMxList in {
896896
defvar Cycles = SiFive7GetCyclesDefault<mx>.c;
@@ -1190,12 +1190,12 @@ defm "" : LMULReadAdvance<"ReadVMSFSV", 0>;
11901190
defm "" : LMULReadAdvance<"ReadVIotaV", 0>;
11911191

11921192
// 17. Vector Permutation Instructions
1193-
def : ReadAdvance<ReadVIMovVX, 0>;
1194-
def : ReadAdvance<ReadVIMovXV, 0>;
1195-
def : ReadAdvance<ReadVIMovXX, 0>;
1196-
def : ReadAdvance<ReadVFMovVF, 0>;
1197-
def : ReadAdvance<ReadVFMovFV, 0>;
1198-
def : ReadAdvance<ReadVFMovFX, 0>;
1193+
def : ReadAdvance<ReadVMovXS, 0>;
1194+
def : ReadAdvance<ReadVMovSX_V, 0>;
1195+
def : ReadAdvance<ReadVMovSX_X, 0>;
1196+
def : ReadAdvance<ReadVMovFS, 0>;
1197+
def : ReadAdvance<ReadVMovSF_V, 0>;
1198+
def : ReadAdvance<ReadVMovSF_F, 0>;
11991199
defm "" : LMULReadAdvance<"ReadVISlideV", 0>;
12001200
defm "" : LMULReadAdvance<"ReadVISlideX", 0>;
12011201
defm "" : LMULReadAdvance<"ReadVFSlideV", 0>;

llvm/lib/Target/RISCV/RISCVScheduleV.td

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ multiclass LMULSEWReadAdvanceImpl<string name, int val, list<SchedWrite> writes
196196
// by the ReadAdvance. For example:
197197
// ```
198198
// defm "" : LMULReadAdvance<"ReadVIALUX", 1,
199-
// LMULSchedWriteList<["WriteVIMovVX"]>.value>;
199+
// LMULSchedWriteList<["WriteVMovSX"]>.value>;
200200
// ```
201201
class LMULSchedWriteListImpl<list<string> names, list<string> MxList> {
202202
list<SchedWrite> value = !foldl([]<SchedWrite>,
@@ -484,11 +484,11 @@ defm "" : LMULSchedWrites<"WriteVIdxV">;
484484

485485
// 16. Vector Permutation Instructions
486486
// 16.1. Integer Scalar Move Instructions
487-
def WriteVIMovVX : SchedWrite;
488-
def WriteVIMovXV : SchedWrite;
487+
def WriteVMovSX : SchedWrite;
488+
def WriteVMovXS : SchedWrite;
489489
// 16.2. Floating-Point Scalar Move Instructions
490-
def WriteVFMovVF : SchedWrite;
491-
def WriteVFMovFV : SchedWrite;
490+
def WriteVMovSF : SchedWrite;
491+
def WriteVMovFS : SchedWrite;
492492
// 16.3. Vector Slide Instructions
493493
defm "" : LMULSchedWrites<"WriteVISlideX">;
494494
defm "" : LMULSchedWrites<"WriteVISlideI">;
@@ -709,13 +709,13 @@ defm "" : LMULSchedReads<"ReadVIotaV">;
709709

710710
// 16. Vector Permutation Instructions
711711
// 16.1. Integer Scalar Move Instructions
712-
def ReadVIMovVX : SchedRead;
713-
def ReadVIMovXV : SchedRead;
714-
def ReadVIMovXX : SchedRead;
712+
def ReadVMovXS : SchedRead;
713+
def ReadVMovSX_V : SchedRead;
714+
def ReadVMovSX_X : SchedRead;
715715
// 16.2. Floating-Point Scalar Move Instructions
716-
def ReadVFMovVF : SchedRead;
717-
def ReadVFMovFV : SchedRead;
718-
def ReadVFMovFX : SchedRead;
716+
def ReadVMovFS : SchedRead;
717+
def ReadVMovSF_V : SchedRead;
718+
def ReadVMovSF_F : SchedRead;
719719
// 16.3. Vector Slide Instructions
720720
defm "" : LMULSchedReads<"ReadVISlideV">;
721721
defm "" : LMULSchedReads<"ReadVISlideX">;
@@ -921,10 +921,10 @@ defm "" : LMULWriteRes<"WriteVIotaV", []>;
921921
defm "" : LMULWriteRes<"WriteVIdxV", []>;
922922

923923
// 16. Vector Permutation Instructions
924-
def : WriteRes<WriteVIMovVX, []>;
925-
def : WriteRes<WriteVIMovXV, []>;
926-
def : WriteRes<WriteVFMovVF, []>;
927-
def : WriteRes<WriteVFMovFV, []>;
924+
def : WriteRes<WriteVMovSX, []>;
925+
def : WriteRes<WriteVMovXS, []>;
926+
def : WriteRes<WriteVMovSF, []>;
927+
def : WriteRes<WriteVMovFS, []>;
928928
defm "" : LMULWriteRes<"WriteVISlideX", []>;
929929
defm "" : LMULWriteRes<"WriteVISlideI", []>;
930930
defm "" : LMULWriteRes<"WriteVISlide1X", []>;
@@ -1082,12 +1082,12 @@ defm "" : LMULReadAdvance<"ReadVMSFSV", 0>;
10821082
defm "" : LMULReadAdvance<"ReadVIotaV", 0>;
10831083

10841084
// 16. Vector Permutation Instructions
1085-
def : ReadAdvance<ReadVIMovVX, 0>;
1086-
def : ReadAdvance<ReadVIMovXV, 0>;
1087-
def : ReadAdvance<ReadVIMovXX, 0>;
1088-
def : ReadAdvance<ReadVFMovVF, 0>;
1089-
def : ReadAdvance<ReadVFMovFV, 0>;
1090-
def : ReadAdvance<ReadVFMovFX, 0>;
1085+
def : ReadAdvance<ReadVMovXS, 0>;
1086+
def : ReadAdvance<ReadVMovSX_V, 0>;
1087+
def : ReadAdvance<ReadVMovSX_X, 0>;
1088+
def : ReadAdvance<ReadVMovFS, 0>;
1089+
def : ReadAdvance<ReadVMovSF_V, 0>;
1090+
def : ReadAdvance<ReadVMovSF_F, 0>;
10911091
defm "" : LMULReadAdvance<"ReadVISlideV", 0>;
10921092
defm "" : LMULReadAdvance<"ReadVISlideX", 0>;
10931093
defm "" : LMULReadAdvance<"ReadVFSlideV", 0>;

0 commit comments

Comments
 (0)