Reorder checks (Addressing review comment)

hazzlim · hazzlim · commit f2fad1bc9f33 · 2024-08-13T10:23:56.000Z
diff --git a/llvm/lib/Analysis/BasicAliasAnalysis.cpp b/llvm/lib/Analysis/BasicAliasAnalysis.cpp
@@ -1259,7 +1259,7 @@ AliasResult BasicAAResult::aliasGEP(
 
     bool IndicesFromRight = DecompGEP1.VarIndices.front().IsNegated == Swapped;
     if (IndicesFromRight && DecompRight.NWFlags->hasNoUnsignedWrap())
-      if (!VLeftSize.isScalable() && VLeftSize.hasValue() &&
+      if (VLeftSize.hasValue() && !VLeftSize.isScalable() &&
           Off.abs().uge(VLeftSize.getValue()))
         return AliasResult::NoAlias;
   }

Original file line number	Diff line number	Diff line change
`@@ -1259,7 +1259,7 @@ AliasResult BasicAAResult::aliasGEP(`
`1259`	`1259`
`1260`	`1260`	`bool IndicesFromRight = DecompGEP1.VarIndices.front().IsNegated == Swapped;`
`1261`	`1261`	`if (IndicesFromRight && DecompRight.NWFlags->hasNoUnsignedWrap())`
`1262`		`- if (!VLeftSize.isScalable() && VLeftSize.hasValue() &&`
	`1262`	`+ if (VLeftSize.hasValue() && !VLeftSize.isScalable() &&`
`1263`	`1263`	`Off.abs().uge(VLeftSize.getValue()))`
`1264`	`1264`	`return AliasResult::NoAlias;`
`1265`	`1265`	`}`