Skip to content

Commit f34b454

Browse files
author
Zoran Jovanovic
committed
[mips] Emit two CFI offset directives per double precision SDC1/LDC1
instead of just one for FR=1 registers Differential Revision: http://reviews.llvm.org/D4310 llvm-svn: 212769
1 parent 3c4780e commit f34b454

File tree

4 files changed

+75
-4
lines changed

4 files changed

+75
-4
lines changed

llvm/lib/Target/Mips/MipsCallingConv.td

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,9 @@ def RetCC_MipsO32 : CallingConv<[
2626
// f32 are returned in registers F0, F2
2727
CCIfType<[f32], CCAssignToReg<[F0, F2]>>,
2828

29-
// f64 arguments are returned in D0_64 and D1_64 in FP64bit mode or
29+
// f64 arguments are returned in D0_64 and D2_64 in FP64bit mode or
3030
// in D0 and D1 in FP32bit mode.
31-
CCIfType<[f64], CCIfSubtarget<"isFP64bit()", CCAssignToReg<[D0_64, D1_64]>>>,
31+
CCIfType<[f64], CCIfSubtarget<"isFP64bit()", CCAssignToReg<[D0_64, D2_64]>>>,
3232
CCIfType<[f64], CCIfSubtarget<"isNotFP64bit()", CCAssignToReg<[D0, D1]>>>
3333
]>;
3434

@@ -247,8 +247,9 @@ def CSR_O32_FPXX : CalleeSavedRegs<(add (sequence "D%u", 15, 10), RA, FP,
247247
def CSR_O32 : CalleeSavedRegs<(add (sequence "D%u", 15, 10), RA, FP,
248248
(sequence "S%u", 7, 0))>;
249249

250-
def CSR_O32_FP64 : CalleeSavedRegs<(add (sequence "D%u_64", 31, 20), RA, FP,
251-
(sequence "S%u", 7, 0))>;
250+
def CSR_O32_FP64 :
251+
CalleeSavedRegs<(add (decimate (sequence "D%u_64", 30, 20), 2), RA, FP,
252+
(sequence "S%u", 7, 0))>;
252253

253254
def CSR_N32 : CalleeSavedRegs<(add D20_64, D22_64, D24_64, D26_64, D28_64,
254255
D30_64, RA_64, FP_64, GP_64,

llvm/lib/Target/Mips/MipsSEFrameLowering.cpp

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -343,6 +343,22 @@ void MipsSEFrameLowering::emitPrologue(MachineFunction &MF) const {
343343
MCCFIInstruction::createOffset(nullptr, Reg1, Offset + 4));
344344
BuildMI(MBB, MBBI, dl, TII.get(TargetOpcode::CFI_INSTRUCTION))
345345
.addCFIIndex(CFIIndex);
346+
} else if (Mips::FGR64RegClass.contains(Reg)) {
347+
unsigned Reg0 = MRI->getDwarfRegNum(Reg, true);
348+
unsigned Reg1 = MRI->getDwarfRegNum(Reg, true) + 1;
349+
350+
if (!STI.isLittle())
351+
std::swap(Reg0, Reg1);
352+
353+
unsigned CFIIndex = MMI.addFrameInst(
354+
MCCFIInstruction::createOffset(nullptr, Reg0, Offset));
355+
BuildMI(MBB, MBBI, dl, TII.get(TargetOpcode::CFI_INSTRUCTION))
356+
.addCFIIndex(CFIIndex);
357+
358+
CFIIndex = MMI.addFrameInst(
359+
MCCFIInstruction::createOffset(nullptr, Reg1, Offset + 4));
360+
BuildMI(MBB, MBBI, dl, TII.get(TargetOpcode::CFI_INSTRUCTION))
361+
.addCFIIndex(CFIIndex);
346362
} else {
347363
// Reg is either in GPR32 or FGR32.
348364
unsigned CFIIndex = MMI.addFrameInst(MCCFIInstruction::createOffset(

llvm/test/CodeGen/Mips/cconv/return-hard-float.ll

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@
1010
; RUN: llc -mtriple=mips64-linux-gnu -relocation-model=static -mattr=-n64,+n64 < %s | FileCheck --check-prefix=ALL --check-prefix=N64 %s
1111
; RUN: llc -mtriple=mips64el-linux-gnu -relocation-model=static -mattr=-n64,+n64 < %s | FileCheck --check-prefix=ALL --check-prefix=N64 %s
1212

13+
; RUN: llc -mtriple=mips-linux-gnu -relocation-model=static -mattr=+o32,+fp64 < %s | FileCheck --check-prefix=ALL --check-prefix=032FP64 %s
14+
; RUN: llc -mtriple=mipsel-linux-gnu -relocation-model=static -mattr=+o32,+fp64 < %s | FileCheck --check-prefix=ALL --check-prefix=032FP64 %s
15+
1316
; Test the float returns for all ABI's and byte orders as specified by
1417
; section 5 of MD00305 (MIPS ABIs Described).
1518

@@ -44,3 +47,13 @@ entry:
4447
; N32-DAG: ldc1 $f0, %lo(double)([[R1:\$[0-9]+]])
4548
; N64-DAG: ld [[R1:\$[0-9]+]], %got_disp(double)($1)
4649
; N64-DAG: ldc1 $f0, 0([[R1]])
50+
51+
define { double, double } @retComplexDouble() #0 {
52+
%retval = alloca { double, double }, align 8
53+
%1 = load { double, double }* %retval
54+
ret { double, double } %1
55+
}
56+
57+
; ALL-LABEL: retComplexDouble:
58+
; 032FP64-DAG: ldc1 $f0, 0($sp)
59+
; 032FP64-DAG: ldc1 $f2, 8($sp)

llvm/test/CodeGen/Mips/cfi_offset.ll

Lines changed: 41 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
1+
; RUN: llc -march=mips -mattr=+o32 < %s | FileCheck %s --check-prefix=CHECK --check-prefix=CHECK-EB
2+
; RUN: llc -march=mipsel -mattr=+o32 < %s | FileCheck %s --check-prefix=CHECK --check-prefix=CHECK-EL
3+
; RUN: llc -march=mips -mattr=+o32,+fpxx < %s | FileCheck %s --check-prefix=CHECK --check-prefix=CHECK-EB
4+
; RUN: llc -march=mipsel -mattr=+o32,+fpxx < %s | FileCheck %s --check-prefix=CHECK --check-prefix=CHECK-EL
5+
; RUN: llc -march=mips -mattr=+o32,+fp64 < %s | FileCheck %s --check-prefix=CHECK --check-prefix=CHECK-EB
6+
; RUN: llc -march=mipsel -mattr=+o32,+fp64 < %s | FileCheck %s --check-prefix=CHECK --check-prefix=CHECK-EL
7+
8+
@var = global double 0.0
9+
10+
declare void @foo(...)
11+
12+
define void @bar() {
13+
14+
; CHECK-LABEL: bar:
15+
16+
; CHECK: .cfi_def_cfa_offset 40
17+
; CHECK: sdc1 $f22, 32($sp)
18+
; CHECK: sdc1 $f20, 24($sp)
19+
; CHECK: sw $ra, 20($sp)
20+
; CHECK: sw $16, 16($sp)
21+
22+
; CHECK-EB: .cfi_offset 55, -8
23+
; CHECK-EB: .cfi_offset 54, -4
24+
; CHECK-EB: .cfi_offset 53, -16
25+
; CHECK-EB: .cfi_offset 52, -12
26+
27+
; CHECK-EL: .cfi_offset 54, -8
28+
; CHECK-EL: .cfi_offset 55, -4
29+
; CHECK-EL: .cfi_offset 52, -16
30+
; CHECK-EL: .cfi_offset 53, -12
31+
32+
; CHECK: .cfi_offset 31, -20
33+
; CHECK: .cfi_offset 16, -24
34+
35+
%val1 = load volatile double* @var
36+
%val2 = load volatile double* @var
37+
call void (...)* @foo() nounwind
38+
store volatile double %val1, double* @var
39+
store volatile double %val2, double* @var
40+
ret void
41+
}

0 commit comments

Comments
 (0)