@@ -526,12 +526,11 @@ linalg::dropUnitDims(RewriterBase &rewriter, GenericOp genericOp,
526
526
rewriter.inlineRegionBefore (genericOp.getRegion (), replacementOp.getRegion (),
527
527
replacementOp.getRegion ().begin ());
528
528
// 5a. Replace `linalg.index` operations that refer to the dropped unit
529
- // dimensions.
529
+ // dimensions.
530
530
replaceUnitDimIndexOps (replacementOp, unitDims, rewriter);
531
531
532
532
// 6. If any result type changes, insert a reshape/slice to convert from the
533
- // original
534
- // type to the new type.
533
+ // original type to the new type.
535
534
SmallVector<Value> resultReplacements;
536
535
for (auto [index, result] : llvm::enumerate (replacementOp.getResults ())) {
537
536
unsigned opOperandIndex = index + replacementOp.getNumDpsInputs ();
@@ -789,8 +788,6 @@ static void
789
788
populateFoldUnitExtentDimsViaSlicesPatterns (RewritePatternSet &patterns,
790
789
ControlDropUnitDims &options) {
791
790
auto *context = patterns.getContext ();
792
- options.rankReductionStrategy =
793
- ControlDropUnitDims::RankReductionStrategy::ExtractInsertSlice;
794
791
patterns.add <DropUnitDims>(context, options);
795
792
patterns.add <DropPadUnitDims>(context, options);
796
793
// TODO: Patterns unrelated to unit dim folding should be factored out.
0 commit comments