Skip to content

Commit f3b4e47

Browse files
authored
[mlir][linalg][NFC] Drop redundant rankReductionStrategy (#107875)
This patch drop redundant rankReductionStrategy in `populateFoldUnitExtentDimsViaSlicesPatterns` and fixes comment typos.
1 parent 3b22618 commit f3b4e47

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

mlir/lib/Dialect/Linalg/Transforms/DropUnitDims.cpp

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -526,12 +526,11 @@ linalg::dropUnitDims(RewriterBase &rewriter, GenericOp genericOp,
526526
rewriter.inlineRegionBefore(genericOp.getRegion(), replacementOp.getRegion(),
527527
replacementOp.getRegion().begin());
528528
// 5a. Replace `linalg.index` operations that refer to the dropped unit
529-
// dimensions.
529+
// dimensions.
530530
replaceUnitDimIndexOps(replacementOp, unitDims, rewriter);
531531

532532
// 6. If any result type changes, insert a reshape/slice to convert from the
533-
// original
534-
// type to the new type.
533+
// original type to the new type.
535534
SmallVector<Value> resultReplacements;
536535
for (auto [index, result] : llvm::enumerate(replacementOp.getResults())) {
537536
unsigned opOperandIndex = index + replacementOp.getNumDpsInputs();
@@ -789,8 +788,6 @@ static void
789788
populateFoldUnitExtentDimsViaSlicesPatterns(RewritePatternSet &patterns,
790789
ControlDropUnitDims &options) {
791790
auto *context = patterns.getContext();
792-
options.rankReductionStrategy =
793-
ControlDropUnitDims::RankReductionStrategy::ExtractInsertSlice;
794791
patterns.add<DropUnitDims>(context, options);
795792
patterns.add<DropPadUnitDims>(context, options);
796793
// TODO: Patterns unrelated to unit dim folding should be factored out.

0 commit comments

Comments
 (0)