Skip to content

Commit f4c76bb

Browse files
[clang] Use llvm::append_range (NFC) (#136256)
This patch replaces: llvm::copy(Src, std::back_inserter(Dst)); with: llvm::append_range(Dst, Src); for breavity. One side benefit is that llvm::append_range eventually calls llvm::SmallVector::reserve if Dst is of llvm::SmallVector.
1 parent e0a6905 commit f4c76bb

File tree

7 files changed

+11
-11
lines changed

7 files changed

+11
-11
lines changed

clang/lib/CodeGen/Targets/AArch64.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -699,7 +699,7 @@ bool AArch64ABIInfo::passAsPureScalableType(
699699
return false;
700700

701701
for (uint64_t I = 0; I < NElt; ++I)
702-
llvm::copy(EltCoerceToSeq, std::back_inserter(CoerceToSeq));
702+
llvm::append_range(CoerceToSeq, EltCoerceToSeq);
703703

704704
NVec += NElt * NV;
705705
NPred += NElt * NP;
@@ -818,7 +818,7 @@ void AArch64ABIInfo::flattenType(
818818
flattenType(AT->getElementType(), EltFlattened);
819819

820820
for (uint64_t I = 0; I < NElt; ++I)
821-
llvm::copy(EltFlattened, std::back_inserter(Flattened));
821+
llvm::append_range(Flattened, EltFlattened);
822822
return;
823823
}
824824

clang/lib/Driver/XRayArgs.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ XRayArgs::XRayArgs(const ToolChain &TC, const ArgList &Args) {
157157
// Get the list of modes we want to support.
158158
auto SpecifiedModes = Args.getAllArgValues(options::OPT_fxray_modes);
159159
if (SpecifiedModes.empty())
160-
llvm::copy(XRaySupportedModes, std::back_inserter(Modes));
160+
llvm::append_range(Modes, XRaySupportedModes);
161161
else
162162
for (const auto &Arg : SpecifiedModes) {
163163
// Parse CSV values for -fxray-modes=...
@@ -167,7 +167,7 @@ XRayArgs::XRayArgs(const ToolChain &TC, const ArgList &Args) {
167167
if (M == "none")
168168
Modes.clear();
169169
else if (M == "all")
170-
llvm::copy(XRaySupportedModes, std::back_inserter(Modes));
170+
llvm::append_range(Modes, XRaySupportedModes);
171171
else
172172
Modes.push_back(std::string(M));
173173
}

clang/lib/Sema/SemaConcept.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2012,8 +2012,8 @@ FormulaType SubsumptionChecker::Normalize(const NormalizedConstraint &NC) {
20122012
for (const auto &RTransform : Right) {
20132013
Clause Combined;
20142014
Combined.reserve(LTransform.size() + RTransform.size());
2015-
llvm::copy(LTransform, std::back_inserter(Combined));
2016-
llvm::copy(RTransform, std::back_inserter(Combined));
2015+
llvm::append_range(Combined, LTransform);
2016+
llvm::append_range(Combined, RTransform);
20172017
Add(std::move(Combined));
20182018
}
20192019
}

clang/lib/Sema/SemaSYCL.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ void SemaSYCL::deepTypeCheckForDevice(SourceLocation UsedAt,
135135
// When nullptr is discovered, this means we've gone back up a level, so
136136
// the history should be cleaned.
137137
StackForRecursion.push_back(nullptr);
138-
llvm::copy(RecDecl->fields(), std::back_inserter(StackForRecursion));
138+
llvm::append_range(StackForRecursion, RecDecl->fields());
139139
}
140140
} while (!StackForRecursion.empty());
141141
}

clang/tools/clang-installapi/ClangInstallAPI.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ static bool runFrontend(StringRef ProgName, Twine Label, bool Verbose,
5959
// headers.
6060
std::vector<std::string> Args = {ProgName.data(), "-target",
6161
Ctx.Slice->getTriple().str().c_str()};
62-
llvm::copy(InitialArgs, std::back_inserter(Args));
62+
llvm::append_range(Args, InitialArgs);
6363
Args.push_back(InputFile);
6464

6565
// Create & run invocation.

clang/tools/clang-installapi/Options.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -691,7 +691,7 @@ Options::processAndFilterOutInstallAPIOptions(ArrayRef<const char *> Args) {
691691
if (A->getOption().getID() > (unsigned)OPT_UNKNOWN) {
692692
ClangDriverArgs.push_back(A->getSpelling().data());
693693
} else
694-
llvm::copy(A->getValues(), std::back_inserter(ClangDriverArgs));
694+
llvm::append_range(ClangDriverArgs, A->getValues());
695695
}
696696
return ClangDriverArgs;
697697
}
@@ -751,7 +751,7 @@ Options::Options(DiagnosticsEngine &Diag, FileManager *FM,
751751
if (A->isClaimed())
752752
continue;
753753
FrontendArgs.emplace_back(A->getSpelling());
754-
llvm::copy(A->getValues(), std::back_inserter(FrontendArgs));
754+
llvm::append_range(FrontendArgs, A->getValues());
755755
}
756756
}
757757

clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -541,7 +541,7 @@ Expected<StringRef> clang(ArrayRef<StringRef> InputFiles, const ArgList &Args,
541541
else
542542
Arg->render(Args, LinkerArgs);
543543
}
544-
llvm::copy(LinkerArgs, std::back_inserter(CmdArgs));
544+
llvm::append_range(CmdArgs, LinkerArgs);
545545
}
546546

547547
// Pass on -mllvm options to the linker invocation.

0 commit comments

Comments
 (0)