Address review

Author: Zaara Syeda

clang/lib/CodeGen/Targets/PPC.cpp

@@ -302,26 +302,25 @@ void AIXTargetCodeGenInfo::setTargetAttributes(
         M.getDiags().Report(D->getLocation(), diag::warn_toc_unsupported_type)
             << GVId << Msg;
     };
-    if (!Ty || Ty->isIncompleteType()) {
+    if (!Ty || Ty->isIncompleteType())
       reportUnsupportedWarning(EmitDiagnostic, "of incomplete type");
-    } else if (RDecl && RDecl->hasFlexibleArrayMember()) {
+    else if (RDecl && RDecl->hasFlexibleArrayMember())
       reportUnsupportedWarning(EmitDiagnostic,
                                "it contains a flexible array member");
-    } else if (VarD->getTLSKind() != VarDecl::TLS_None) {
+    else if (VarD->getTLSKind() != VarDecl::TLS_None)
       reportUnsupportedWarning(EmitDiagnostic, "of thread local storage");
-    } else if (PointerSize < Context.getTypeInfo(VarD->getType()).Width / 8) {
+    else if (PointerSize < Context.getTypeInfo(VarD->getType()).Width / 8)
       reportUnsupportedWarning(EmitDiagnostic,
                                "variable is larger than a pointer");
-    } else if (PointerSize < Alignment) {
+    else if (PointerSize < Alignment)
       reportUnsupportedWarning(EmitDiagnostic,
                                "variable is aligned wider than a pointer");
-    } else if (D->hasAttr<SectionAttr>()) {
+    else if (D->hasAttr<SectionAttr>())
       reportUnsupportedWarning(EmitDiagnostic,
                                "variable has a section attribute");
-    } else if (GV->hasExternalLinkage() ||
-               (M.getCodeGenOpts().AllTocData && !GV->hasLocalLinkage())) {
+    else if (GV->hasExternalLinkage() ||
+             (M.getCodeGenOpts().AllTocData && !GV->hasLocalLinkage()))
       GVar->addAttribute("toc-data");
-    }
   }
 }
 

llvm/lib/MC/MCSectionXCOFF.cpp

@@ -87,7 +87,7 @@ void MCSectionXCOFF::printSwitchToSection(const MCAsmInfo &MAI, const Triple &T,
     if (getKind().isCommon() && !getKind().isBSSLocal())
       return;
 
-    assert(getKind().isBSS() && "Unexepected section kind for toc-data");
+    assert(getKind().isBSS() && "Unexpected section kind for toc-data");
     printCsectDirective(OS);
     return;
   }

llvm/lib/Target/PowerPC/PPCSubtarget.cpp

@@ -202,11 +202,9 @@ void PPCSubtarget::tocDataChecks(unsigned PointerSize,
     report_fatal_error(
         "A GlobalVariable with size larger than a TOC entry is not currently "
         "supported by the toc data transformation.");
-  if (GV->hasLocalLinkage() || GV->hasPrivateLinkage())
-    report_fatal_error("A GlobalVariable with private or local linkage is not "
+  if (GV->hasPrivateLinkage())
+    report_fatal_error("A GlobalVariable with private linkage is not "
                        "currently supported by the toc data transformation.");
-  assert(!GV->hasCommonLinkage() &&
-         "Tentative definitions cannot have the mapping class XMC_TD.");
 }
 
 bool PPCSubtarget::isGVIndirectSymbol(const GlobalValue *GV) const {

llvm/test/CodeGen/PowerPC/toc-data-struct-array.ll

@@ -34,15 +34,14 @@ attributes #1 = { noinline }
 ; CHECK-NEXT: .space    4
 
 ; OBJ32:  Symbol {
-; OBJ32:    Index: 9
-; OBJ32-NEXT:    Name: a
+; OBJ32:    Name: a
 ; OBJ32-NEXT:    Value (RelocatableAddress): 0x3C
 ; OBJ32-NEXT:    Section: .data
 ; OBJ32-NEXT:    Type: 0x0
 ; OBJ32-NEXT:    StorageClass: C_EXT (0x2)
 ; OBJ32-NEXT:    NumberOfAuxEntries: 1
 ; OBJ32-NEXT:    CSECT Auxiliary Entry {
-; OBJ32-NEXT:      Index: 10
+; OBJ32-NEXT:      Index: {{[0-9]+}}
 ; OBJ32-NEXT:      SectionLen: 2
 ; OBJ32-NEXT:      ParameterHashIndex: 0x0
 ; OBJ32-NEXT:      TypeChkSectNum: 0x0
@@ -54,15 +53,14 @@ attributes #1 = { noinline }
 ; OBJ32-NEXT:    }
 ; OBJ32-NEXT:  }
 ; OBJ32-NEXT:  Symbol {
-; OBJ32-NEXT:    Index: 11
-; OBJ32-NEXT:    Name: b
+; OBJ32:    Name: b
 ; OBJ32-NEXT:    Value (RelocatableAddress): 0x40
 ; OBJ32-NEXT:    Section: .data
 ; OBJ32-NEXT:    Type: 0x0
 ; OBJ32-NEXT:    StorageClass: C_EXT (0x2)
 ; OBJ32-NEXT:    NumberOfAuxEntries: 1
 ; OBJ32-NEXT:    CSECT Auxiliary Entry {
-; OBJ32-NEXT:      Index: 12
+; OBJ32-NEXT:      Index: {{[0-9]+}}
 ; OBJ32-NEXT:      SectionLen: 4
 ; OBJ32-NEXT:      ParameterHashIndex: 0x0
 ; OBJ32-NEXT:      TypeChkSectNum: 0x0
@@ -75,15 +73,14 @@ attributes #1 = { noinline }
 ; OBJ32-NEXT:  }
 
 ; OBJ64:  Symbol {
-; OBJ64:    Index: 9
-; OBJ64-NEXT:    Name: a
+; OBJ64:    Name: a
 ; OBJ64-NEXT:    Value (RelocatableAddress): 0x48
 ; OBJ64-NEXT:    Section: .data
 ; OBJ64-NEXT:    Type: 0x0
 ; OBJ64-NEXT:    StorageClass: C_EXT (0x2)
 ; OBJ64-NEXT:    NumberOfAuxEntries: 1
 ; OBJ64-NEXT:    CSECT Auxiliary Entry {
-; OBJ64-NEXT:      Index: 10
+; OBJ64-NEXT:      Index: {{[0-9]+}}
 ; OBJ64-NEXT:      SectionLen: 2
 ; OBJ64-NEXT:      ParameterHashIndex: 0x0
 ; OBJ64-NEXT:      TypeChkSectNum: 0x0
@@ -94,15 +91,14 @@ attributes #1 = { noinline }
 ; OBJ64-NEXT:    }
 ; OBJ64-NEXT:  }
 ; OBJ64-NEXT:  Symbol {
-; OBJ64-NEXT:    Index: 11
-; OBJ64-NEXT:    Name: b
+; OBJ64:    Name: b
 ; OBJ64-NEXT:    Value (RelocatableAddress): 0x4C
 ; OBJ64-NEXT:    Section: .data
 ; OBJ64-NEXT:    Type: 0x0
 ; OBJ64-NEXT:    StorageClass: C_EXT (0x2)
 ; OBJ64-NEXT:    NumberOfAuxEntries: 1
 ; OBJ64-NEXT:    CSECT Auxiliary Entry {
-; OBJ64-NEXT:      Index: 12
+; OBJ64-NEXT:      Index: {{[0-9]+}}
 ; OBJ64-NEXT:      SectionLen: 4
 ; OBJ64-NEXT:      ParameterHashIndex: 0x0
 ; OBJ64-NEXT:      TypeChkSectNum: 0x0