Skip to content

Commit f6463c4

Browse files
committed
!fixup drop FIXME, update new test from 9e0ea8c.
1 parent 3d907eb commit f6463c4

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

llvm/test/Transforms/InstCombine/loadstore-metadata.ll

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,6 @@ entry:
201201
ret ptr %l.sel
202202
}
203203

204-
; FIXME: Should preserve metadata on loads.
205204
define double @preserve_load_metadata_after_select_transform2(ptr %a, ptr %b) {
206205
; CHECK-LABEL: @preserve_load_metadata_after_select_transform2(
207206
; CHECK-NEXT: entry:
@@ -220,7 +219,6 @@ entry:
220219
ret double %l.sel
221220
}
222221

223-
; FIXME: Should preserve metadata on loads.
224222
define double @preserve_load_metadata_after_select_transform_metadata_missing_1(ptr %a, ptr %b) {
225223
; CHECK-LABEL: @preserve_load_metadata_after_select_transform_metadata_missing_1(
226224
; CHECK-NEXT: entry:
@@ -257,7 +255,6 @@ entry:
257255
ret double %l.sel
258256
}
259257

260-
; FIXME: Should preserve metadata on loads.
261258
define double @preserve_load_metadata_after_select_transform_metadata_missing_3(ptr %a, ptr %b) {
262259
; CHECK-LABEL: @preserve_load_metadata_after_select_transform_metadata_missing_3(
263260
; CHECK-NEXT: entry:
@@ -276,14 +273,13 @@ entry:
276273
ret double %l.sel
277274
}
278275

279-
; FIXME: Should preserve metadata on loads.
280276
; Like preserve_load_metadata_after_select_transform_metadata_missing_3, but
281277
; with different access groups on all loads.
282278
define double @preserve_load_metadata_after_select_transform_metadata_missing_4(ptr %a, ptr %b) {
283279
; CHECK-LABEL: @preserve_load_metadata_after_select_transform_metadata_missing_4(
284280
; CHECK-NEXT: entry:
285-
; CHECK-NEXT: [[L_A:%.*]] = load double, ptr [[A:%.*]], align 8
286-
; CHECK-NEXT: [[L_B:%.*]] = load double, ptr [[B:%.*]], align 8
281+
; CHECK-NEXT: [[L_A:%.*]] = load double, ptr [[A:%.*]], align 8, !llvm.access.group [[META6]]
282+
; CHECK-NEXT: [[L_B:%.*]] = load double, ptr [[B:%.*]], align 8, !llvm.access.group [[META6]]
287283
; CHECK-NEXT: [[CMP_I:%.*]] = fcmp fast olt double [[L_A]], [[L_B]]
288284
; CHECK-NEXT: [[L_SEL:%.*]] = select i1 [[CMP_I]], double [[L_B]], double [[L_A]]
289285
; CHECK-NEXT: ret double [[L_SEL]]

0 commit comments

Comments
 (0)