fix error handling

HerrCai0907 · HerrCai0907 · commit f76fc26378f8 · 2024-12-19T23:59:58.000+08:00
diff --git a/clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp b/clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp
@@ -564,7 +564,7 @@ int clangTidyMain(int argc, const char **argv) {
           : llvm::cl::TokenizeGNUCommandLine;
   llvm::cl::ExpansionContext ECtx(Alloc, Tokenizer);
   if (llvm::Error Err = ECtx.expandResponseFiles(Args)) {
-    llvm::WithColor::error() << Err << "\n";
+    llvm::WithColor::error() << llvm::toString(std::move(Err)) << "\n";
     return 1;
   }
   argc = static_cast<int>(Args.size());
diff --git a/clang-tools-extra/test/clang-tidy/infrastructure/read-parameters-from-file-error.cpp b/clang-tools-extra/test/clang-tidy/infrastructure/read-parameters-from-file-error.cpp
@@ -0,0 +1,3 @@
+// RUN: echo @%t.param > %t.param && not clang-tidy %s @%t.param -- 2>&1 | FileCheck %s
+
+// CHECK: recursive expansion of

Original file line number	Diff line number	Diff line change
`@@ -564,7 +564,7 @@ int clangTidyMain(int argc, const char **argv) {`
`564`	`564`	`: llvm::cl::TokenizeGNUCommandLine;`
`565`	`565`	`llvm::cl::ExpansionContext ECtx(Alloc, Tokenizer);`
`566`	`566`	`if (llvm::Error Err = ECtx.expandResponseFiles(Args)) {`
`567`		`- llvm::WithColor::error() << Err << "\n";`
	`567`	`+ llvm::WithColor::error() << llvm::toString(std::move(Err)) << "\n";`
`568`	`568`	`return 1;`
`569`	`569`	`}`
`570`	`570`	`argc = static_cast<int>(Args.size());`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+// RUN: echo @%t.param > %t.param && not clang-tidy %s @%t.param -- 2>&1 \| FileCheck %s`
	`2`	`+`
	`3`	`+// CHECK: recursive expansion of`