[flang] Fix warning in build (#100134)

psteinfeld · yuxuanchen1997 · commit f8183ce34ffb · 2024-07-25T12:51:50.000-07:00
Summary: After tblah's update #99817, I'm getting a warning about an unusedvariable. It looks to me like the warning is bogus, possibly due to a bug in the compiler I'm using (GCC 9.3.0). But adding a "maybe_unused" clause fixes it and makes my builds clean. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D60251162
diff --git a/flang/lib/Lower/DirectivesCommon.h b/flang/lib/Lower/DirectivesCommon.h
@@ -137,7 +137,8 @@ static inline void genOmpAtomicHintAndMemoryOrderClauses(
 }
 
 template <typename AtomicListT>
-static void processOmpAtomicTODO(mlir::Type elementType, mlir::Location loc) {
+static void processOmpAtomicTODO(mlir::Type elementType,
+                                 [[maybe_unused]] mlir::Location loc) {
   if (!elementType)
     return;
   if constexpr (std::is_same<AtomicListT,

Original file line number	Diff line number	Diff line change
`@@ -137,7 +137,8 @@ static inline void genOmpAtomicHintAndMemoryOrderClauses(`
`137`	`137`	`}`
`138`	`138`
`139`	`139`	`template <typename AtomicListT>`
`140`		`-static void processOmpAtomicTODO(mlir::Type elementType, mlir::Location loc) {`
	`140`	`+static void processOmpAtomicTODO(mlir::Type elementType,`
	`141`	`+ [[maybe_unused]] mlir::Location loc) {`
`141`	`142`	`if (!elementType)`
`142`	`143`	`return;`
`143`	`144`	`if constexpr (std::is_same<AtomicListT,`