Skip to content

Commit f822950

Browse files
committed
Address review comment
1 parent 1b42b13 commit f822950

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

llvm/include/llvm/CodeGen/TileShapeInfo.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ class ShapeT {
3636
}
3737
// When ShapeT has mult shapes, we only use Shapes (never use Row and Col)
3838
// and ImmShapes. Due to the most case is only one shape (just simply use
39-
// Shape.Row or Shape.Col), so here we don't merge Row and Col into vertor
39+
// Shape.Row or Shape.Col), so here we don't merge Row and Col into vector
4040
// Shapes to keep the speed and code simplicity.
4141
// TODO: The upper solution is a temporary way to minimize current tile
4242
// register allocation code changes. It can not handle both Reg shape and

llvm/lib/Target/X86/X86ExpandPseudo.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -615,7 +615,7 @@ bool X86ExpandPseudo::expandMI(MachineBasicBlock &MBB,
615615
MBB.erase(MBBI);
616616
return true;
617617
}
618-
// Smilar with TILEPAIRLOAD, TILEPAIRSTORE is just for TILEPair spill, no
618+
// Similar with TILEPAIRLOAD, TILEPAIRSTORE is just for TILEPair spill, no
619619
// corresponding AMX instruction to support it. So, split it too:
620620
// "TILEPAIRSTORE Base, Scale, Index, Offset, Segment, TMM0:TMM1" -->
621621
// "TILESTORE Base, Scale, Index, Offset, Segment, TMM0" +

llvm/lib/Target/X86/X86FastPreTileConfig.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,7 @@ void X86FastPreTileConfig::reload(MachineBasicBlock::iterator UseMI,
268268
<< printReg(TileReg, TRI) << '\n');
269269
}
270270

271-
unsigned getTileDefNum(MachineRegisterInfo *MRI, Register Reg) {
271+
static unsigned getTileDefNum(MachineRegisterInfo *MRI, Register Reg) {
272272
if (Reg.isVirtual()) {
273273
unsigned RegClassID = MRI->getRegClass(Reg)->getID();
274274
if (RegClassID == X86::TILERegClassID)

llvm/lib/TargetParser/Host.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1875,8 +1875,8 @@ const StringMap<bool> sys::getHostCPUFeatures() {
18751875
MaxLevel >= 0x19 && !getX86CpuIDAndInfo(0x19, &EAX, &EBX, &ECX, &EDX);
18761876
Features["widekl"] = HasLeaf7 && HasLeaf19 && ((EBX >> 2) & 1);
18771877

1878-
bool HasLeaf1E =
1879-
MaxLevel >= 0x1e && !getX86CpuIDAndInfo(0x1e, &EAX, &EBX, &ECX, &EDX);
1878+
bool HasLeaf1E = MaxLevel >= 0x1e &&
1879+
!getX86CpuIDAndInfoEx(0x1e, 0x1, &EAX, &EBX, &ECX, &EDX);
18801880
Features["amx-transpose"] = HasLeaf1E && ((EAX >> 5) & 1) && HasAMXSave;
18811881

18821882
bool HasLeaf24 =

0 commit comments

Comments
 (0)