Skip to content

Commit f8356d3

Browse files
committed
address review comments
1 parent b42222b commit f8356d3

File tree

6 files changed

+16
-8
lines changed

6 files changed

+16
-8
lines changed

libc/src/sys/uio/linux/CMakeLists.txt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,12 @@ add_entrypoint_object(
55
HDRS
66
../writev.h
77
DEPENDS
8+
libc.hdr.types.ssize_t
9+
libc.hdr.types.struct_iovec
810
libc.include.sys_syscall
911
libc.src.__support.OSUtil.osutil
1012
libc.src.__support.common
1113
libc.src.errno.errno
12-
libc.hdr.types.ssize_t
13-
libc.hdr.types.struct_iovec
1414
)
1515

1616
add_entrypoint_object(
@@ -20,10 +20,10 @@ add_entrypoint_object(
2020
HDRS
2121
../readv.h
2222
DEPENDS
23+
libc.hdr.types.ssize_t
24+
libc.hdr.types.struct_iovec
2325
libc.include.sys_syscall
2426
libc.src.__support.OSUtil.osutil
2527
libc.src.__support.common
2628
libc.src.errno.errno
27-
libc.hdr.types.ssize_t
28-
libc.hdr.types.struct_iovec
2929
)

libc/src/sys/uio/linux/readv.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@
66
//
77
//===----------------------------------------------------------------------===//
88
#include "src/sys/uio/readv.h"
9+
#include "hdr/types/ssize_t.h"
10+
#include "hdr/types/struct_iovec.h"
911
#include "src/__support/OSUtil/syscall.h"
1012
#include "src/__support/common.h"
1113
#include "src/errno/libc_errno.h"

libc/src/sys/uio/linux/writev.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@
66
//
77
//===----------------------------------------------------------------------===//
88
#include "src/sys/uio/writev.h"
9+
#include "hdr/types/ssize_t.h"
10+
#include "hdr/types/struct_iovec.h"
911
#include "src/__support/OSUtil/syscall.h"
1012
#include "src/__support/common.h"
1113
#include "src/errno/libc_errno.h"

libc/test/src/sys/uio/CMakeLists.txt

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,12 @@ add_libc_unittest(
77
SRCS
88
writev_test.cpp
99
DEPENDS
10-
libc.src.errno.errno
10+
libc.hdr.types.struct_iovec
1111
libc.src.__support.common
12+
libc.src.errno.errno
13+
libc.src.fcntl.open
1214
libc.src.sys.uio.writev
1315
libc.src.unistd.close
14-
libc.src.fcntl.open
1516
libc.test.UnitTest.ErrnoSetterMatcher
1617
)
1718

@@ -22,10 +23,11 @@ add_libc_unittest(
2223
SRCS
2324
readv_test.cpp
2425
DEPENDS
25-
libc.src.errno.errno
26+
libc.hdr.types.struct_iovec
2627
libc.src.__support.common
28+
libc.src.errno.errno
29+
libc.src.fcntl.open
2730
libc.src.sys.uio.readv
2831
libc.src.unistd.close
29-
libc.src.fcntl.open
3032
libc.test.UnitTest.ErrnoSetterMatcher
3133
)

libc/test/src/sys/uio/readv_test.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
//
77
//===----------------------------------------------------------------------===//
88

9+
#include "hdr/types/struct_iovec.h"
910
#include "src/fcntl/open.h"
1011
#include "src/sys/uio/readv.h"
1112
#include "src/unistd/close.h"

libc/test/src/sys/uio/writev_test.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
//
77
//===----------------------------------------------------------------------===//
88

9+
#include "hdr/types/struct_iovec.h"
910
#include "src/fcntl/open.h"
1011
#include "src/sys/uio/writev.h"
1112
#include "src/unistd/close.h"

0 commit comments

Comments
 (0)