Skip to content

Commit f8a3b89

Browse files
committed
Fixes
1 parent 0b06b06 commit f8a3b89

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

clang-tools-extra/clang-tidy/readability/ImplicitBoolConversionCheck.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -160,8 +160,7 @@ bool needsSpacePrefix(SourceLocation Loc, ASTContext &Context) {
160160
return true;
161161

162162
const StringRef AllowedCharacters(" \t\n\v\f\r(){}[]<>;,+=-|&~!^*/");
163-
return SpaceBeforeStmtStr.rtrim(AllowedCharacters).size() ==
164-
SpaceBeforeStmtStr.size();
163+
return !AllowedCharacters.contains(SpaceBeforeStmtStr.back());
165164
}
166165

167166
void fixGenericExprCastFromBool(DiagnosticBuilder &Diag,

clang-tools-extra/test/clang-tidy/checkers/readability/implicit-bool-conversion.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -529,7 +529,7 @@ namespace PR71848 {
529529
int fun() {
530530
bool foo = false;
531531
return( foo );
532-
// CHECK-MESSAGES: :[[@LINE-1]]:11: warning: implicit conversion bool -> 'int' [readability-implicit-bool-conversion]
532+
// CHECK-MESSAGES: :[[@LINE-1]]:11: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
533533
// CHECK-FIXES: return static_cast<int>( foo );
534534
}
535535
}

0 commit comments

Comments
 (0)