Refine vectorBuilder

Mel-Chen · Mel-Chen · commit f98d7408a779 · 2024-07-14T23:11:46.000-07:00
diff --git a/llvm/lib/IR/VectorBuilder.cpp b/llvm/lib/IR/VectorBuilder.cpp
@@ -97,12 +97,10 @@ Value *VectorBuilder::createSimpleTargetReduction(RecurKind Kind, Type *ValTy,
     case RecurKind::FMinimum:
       return Intrinsic::vp_reduce_fminimum;
     default:
-      return Intrinsic::not_intrinsic;
+      llvm_unreachable("No VPIntrinsic for this reduction");
     }
   };
   auto VPID = GetForRecurKind(Kind);
-  assert(VPID != Intrinsic::not_intrinsic &&
-         "No VPIntrinsic for this reduction");
   return createVectorInstructionImpl(VPID, ValTy, InstOpArray, Name);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -97,12 +97,10 @@ Value VectorBuilder::createSimpleTargetReduction(RecurKind Kind, Type ValTy,`
`97`	`97`	`case RecurKind::FMinimum:`
`98`	`98`	`return Intrinsic::vp_reduce_fminimum;`
`99`	`99`	`default:`
`100`		`- return Intrinsic::not_intrinsic;`
	`100`	`+ llvm_unreachable("No VPIntrinsic for this reduction");`
`101`	`101`	`}`
`102`	`102`	`};`
`103`	`103`	`auto VPID = GetForRecurKind(Kind);`
`104`		`- assert(VPID != Intrinsic::not_intrinsic &&`
`105`		`- "No VPIntrinsic for this reduction");`
`106`	`104`	`return createVectorInstructionImpl(VPID, ValTy, InstOpArray, Name);`
`107`	`105`	`}`
`108`	`106`