Skip to content

Commit fa17977

Browse files
authored
[libc][bazel] Remove specializations from libc_math_function. (#109802)
There are no more specializations `libc/src/math/x86_64` or `libc/src/math/aarch64` anymore. All implementations are going through the generic implementation.
1 parent 31ac400 commit fa17977

File tree

2 files changed

+10
-64
lines changed

2 files changed

+10
-64
lines changed

utils/bazel/llvm-project-overlay/libc/BUILD.bazel

Lines changed: 9 additions & 54 deletions
Original file line numberDiff line numberDiff line change
@@ -1825,26 +1825,11 @@ libc_math_function(
18251825
],
18261826
)
18271827

1828-
libc_math_function(
1829-
name = "ceil",
1830-
specializations = [
1831-
"generic",
1832-
],
1833-
)
1828+
libc_math_function(name = "ceil")
18341829

1835-
libc_math_function(
1836-
name = "ceilf",
1837-
specializations = [
1838-
"generic",
1839-
],
1840-
)
1830+
libc_math_function(name = "ceilf")
18411831

1842-
libc_math_function(
1843-
name = "ceill",
1844-
specializations = [
1845-
"generic",
1846-
],
1847-
)
1832+
libc_math_function(name = "ceill")
18481833

18491834
libc_math_function(name = "ceilf128")
18501835

@@ -2126,19 +2111,9 @@ libc_math_function(
21262111
],
21272112
)
21282113

2129-
libc_math_function(
2130-
name = "floor",
2131-
specializations = [
2132-
"generic",
2133-
],
2134-
)
2114+
libc_math_function(name = "floor")
21352115

2136-
libc_math_function(
2137-
name = "floorf",
2138-
specializations = [
2139-
"generic",
2140-
],
2141-
)
2116+
libc_math_function(name = "floorf")
21422117

21432118
libc_math_function(name = "floorl")
21442119

@@ -2639,19 +2614,9 @@ libc_math_function(name = "rintl")
26392614

26402615
libc_math_function(name = "rintf128")
26412616

2642-
libc_math_function(
2643-
name = "round",
2644-
specializations = [
2645-
"generic",
2646-
],
2647-
)
2617+
libc_math_function(name = "round")
26482618

2649-
libc_math_function(
2650-
name = "roundf",
2651-
specializations = [
2652-
"generic",
2653-
],
2654-
)
2619+
libc_math_function(name = "roundf")
26552620

26562621
libc_math_function(name = "roundl")
26572622

@@ -2850,19 +2815,9 @@ libc_math_function(name = "totalordermagl")
28502815

28512816
libc_math_function(name = "totalordermagf128")
28522817

2853-
libc_math_function(
2854-
name = "trunc",
2855-
specializations = [
2856-
"generic",
2857-
],
2858-
)
2818+
libc_math_function(name = "trunc")
28592819

2860-
libc_math_function(
2861-
name = "truncf",
2862-
specializations = [
2863-
"generic",
2864-
],
2865-
)
2820+
libc_math_function(name = "truncf")
28662821

28672822
libc_math_function(name = "truncl")
28682823

utils/bazel/llvm-project-overlay/libc/libc_build_rules.bzl

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,6 @@ def libc_function(
129129

130130
def libc_math_function(
131131
name,
132-
specializations = None,
133132
additional_deps = None):
134133
"""Add a target for a math function.
135134
@@ -142,14 +141,6 @@ def libc_math_function(
142141
math function.
143142
"""
144143
additional_deps = additional_deps or []
145-
specializations = specializations or ["generic"]
146-
select_map = {}
147-
if "generic" in specializations:
148-
select_map["//conditions:default"] = ["src/math/generic/" + name + ".cpp"]
149-
if "aarch64" in specializations:
150-
select_map[PLATFORM_CPU_ARM64] = ["src/math/aarch64/" + name + ".cpp"]
151-
if "x86_64" in specializations:
152-
select_map[PLATFORM_CPU_X86_64] = ["src/math/x86_64/" + name + ".cpp"]
153144

154145
#TODO(michaelrj): Fix the floating point dependencies
155146
OLD_FPUTIL_DEPS = [
@@ -166,7 +157,7 @@ def libc_math_function(
166157
]
167158
libc_function(
168159
name = name,
169-
srcs = selects.with_or(select_map),
160+
srcs = ["src/math/generic/" + name + ".cpp"],
170161
hdrs = ["src/math/" + name + ".h"],
171162
deps = [":__support_common"] + OLD_FPUTIL_DEPS + additional_deps,
172163
)

0 commit comments

Comments
 (0)