Address comments

Author: ziqingluo-90

clang/include/clang/AST/FormatString.h

@@ -783,18 +783,6 @@ bool ParsePrintfString(FormatStringHandler &H,
 bool ParseFormatStringHasSArg(const char *beg, const char *end,
                               const LangOptions &LO, const TargetInfo &Target);
 
-/// Parse C format string and return index (relative to `ArgIndex`) of the first
-/// found `s` specifier.  Return 0 if not found.
-/// \param I The start of the C format string; Updated to the first unparsed
-/// position upon return.
-/// \param E The end of the C format string;
-/// \param ArgIndex The argument index of the last found `s` specifier; Or the
-/// argument index of the formatter in initial case.
-unsigned ParseFormatStringFirstSArgIndex(const char *&I, const char *E,
-                                         unsigned ArgIndex,
-                                         const LangOptions &LO,
-                                         const TargetInfo &Target);
-
 bool ParseScanfString(FormatStringHandler &H,
                       const char *beg, const char *end, const LangOptions &LO,
                       const TargetInfo &Target);

clang/lib/AST/PrintfFormatString.cpp

@@ -483,34 +483,6 @@ bool clang::analyze_format_string::ParseFormatStringHasSArg(const char *I,
   return false;
 }
 
-unsigned clang::analyze_format_string::ParseFormatStringFirstSArgIndex(
-    const char *&I, const char *E, unsigned ArgIndex, const LangOptions &LO,
-    const TargetInfo &Target) {
-  unsigned argIndex = ArgIndex;
-
-  // Keep looking for a %s format specifier until we have exhausted the string.
-  FormatStringHandler H;
-  while (I != E) {
-    const PrintfSpecifierResult &FSR =
-        ParsePrintfSpecifier(H, I, E, argIndex, LO, Target, false, false);
-    // Did a fail-stop error of any kind occur when parsing the specifier?
-    // If so, don't do any more processing.
-    if (FSR.shouldStop())
-      return false;
-    // Did we exhaust the string or encounter an error that
-    // we can recover from?
-    if (!FSR.hasValue())
-      continue;
-    const analyze_printf::PrintfSpecifier &FS = FSR.getValue();
-    // Return true if this a %s format specifier.
-    if (FS.getConversionSpecifier().getKind() ==
-        ConversionSpecifier::Kind::sArg) {
-      return FS.getPositionalArgIndex();
-    }
-  }
-  return false;
-}
-
 bool clang::analyze_format_string::parseFormatStringHasFormattingSpecifiers(
     const char *Begin, const char *End, const LangOptions &LO,
     const TargetInfo &Target) {