@@ -16,7 +16,7 @@ using namespace clang::ast_matchers;
16
16
17
17
namespace clang ::tidy::readability {
18
18
19
- static bool areTypesEquals (QualType S, QualType D) {
19
+ static bool areTypesEqual (QualType S, QualType D) {
20
20
if (S == D)
21
21
return true ;
22
22
@@ -29,7 +29,7 @@ static bool areTypesEquals(QualType S, QualType D) {
29
29
QualType PtrD = D->getPointeeType ();
30
30
31
31
if (!PtrS.isNull () && !PtrD.isNull ())
32
- return areTypesEquals (PtrS, PtrD);
32
+ return areTypesEqual (PtrS, PtrD);
33
33
34
34
const DeducedType *DT = S->getContainedDeducedType ();
35
35
if (DT && DT->isDeduced ())
@@ -38,15 +38,15 @@ static bool areTypesEquals(QualType S, QualType D) {
38
38
return false ;
39
39
}
40
40
41
- static bool areTypesEquals (QualType TypeS, QualType TypeD,
42
- bool IgnoreTypeAliases) {
41
+ static bool areTypesEqual (QualType TypeS, QualType TypeD,
42
+ bool IgnoreTypeAliases) {
43
43
const QualType CTypeS = TypeS.getCanonicalType ();
44
44
const QualType CTypeD = TypeD.getCanonicalType ();
45
45
if (CTypeS != CTypeD)
46
46
return false ;
47
47
48
- return IgnoreTypeAliases || areTypesEquals (TypeS.getLocalUnqualifiedType (),
49
- TypeD.getLocalUnqualifiedType ());
48
+ return IgnoreTypeAliases || areTypesEqual (TypeS.getLocalUnqualifiedType (),
49
+ TypeD.getLocalUnqualifiedType ());
50
50
}
51
51
52
52
static bool areBinaryOperatorOperandsTypesEqual (const Expr *E,
@@ -64,13 +64,13 @@ static bool areBinaryOperatorOperandsTypesEqual(const Expr *E,
64
64
const QualType NonReferenceType = Type.getNonReferenceType ();
65
65
const QualType LHSType = B->getLHS ()->IgnoreImplicit ()->getType ();
66
66
if (!LHSType.isNull () &&
67
- !areTypesEquals (LHSType.getNonReferenceType (), NonReferenceType,
68
- IgnoreTypeAliases))
67
+ !areTypesEqual (LHSType.getNonReferenceType (), NonReferenceType,
68
+ IgnoreTypeAliases))
69
69
return true ;
70
70
const QualType RHSType = B->getRHS ()->IgnoreImplicit ()->getType ();
71
71
if (!RHSType.isNull () &&
72
- !areTypesEquals (RHSType.getNonReferenceType (), NonReferenceType,
73
- IgnoreTypeAliases))
72
+ !areTypesEqual (RHSType.getNonReferenceType (), NonReferenceType,
73
+ IgnoreTypeAliases))
74
74
return true ;
75
75
}
76
76
return false ;
@@ -142,7 +142,7 @@ void RedundantCastingCheck::check(const MatchFinder::MatchResult &Result) {
142
142
Result.Nodes .getNodeAs <QualType>(" srcType" )->getNonReferenceType ();
143
143
TypeD = TypeD.getNonReferenceType ();
144
144
145
- if (!areTypesEquals (TypeS, TypeD, IgnoreTypeAliases))
145
+ if (!areTypesEqual (TypeS, TypeD, IgnoreTypeAliases))
146
146
return ;
147
147
148
148
if (areBinaryOperatorOperandsTypesEqual (SourceExpr, IgnoreTypeAliases))
@@ -179,7 +179,6 @@ void RedundantCastingCheck::check(const MatchFinder::MatchResult &Result) {
179
179
}
180
180
181
181
if (utils::fixit::areParensNeededForStatement (*SourceExpr)) {
182
-
183
182
Diag << FixItHint::CreateInsertion (SourceExprBegin, " (" )
184
183
<< FixItHint::CreateInsertion (NextToken, " )" );
185
184
}
0 commit comments