Apply suggestions from code review

ashgti · JDevlieghere · ashgti · commit fad22ceb10f6 · 2025-02-24T14:06:56.000-08:00
Co-authored-by: Jonas Devlieghere &lt;jonas@devlieghere.com&gt;
diff --git a/lldb/tools/lldb-dap/JSONUtils.cpp b/lldb/tools/lldb-dap/JSONUtils.cpp
@@ -819,7 +819,7 @@ llvm::json::Value CreateStackFrame(lldb::SBFrame &frame,
                                frame.GetSymbol().GetStartAddress().GetOffset();
     lldb::addr_t inst_line =
         inst_offset / (frame.GetThread().GetProcess().GetAddressByteSize() / 2);
-    // lines are base-1 indexed
+    // Line numbers are 1-based. 
     object.try_emplace("line", inst_line + 1);
     object.try_emplace("column", 1);
   }

Original file line number	Diff line number	Diff line change
`@@ -819,7 +819,7 @@ llvm::json::Value CreateStackFrame(lldb::SBFrame &frame,`
`819`	`819`	`frame.GetSymbol().GetStartAddress().GetOffset();`
`820`	`820`	`lldb::addr_t inst_line =`
`821`	`821`	`inst_offset / (frame.GetThread().GetProcess().GetAddressByteSize() / 2);`
`822`		`- // lines are base-1 indexed`
	`822`	`+ // Line numbers are 1-based.`
`823`	`823`	`object.try_emplace("line", inst_line + 1);`
`824`	`824`	`object.try_emplace("column", 1);`
`825`	`825`	`}`