Skip to content

Commit fb170fd

Browse files
committed
tests: XFAIL/UNSUPPORTED tests on Windows
Now that we are building the python bindings on Windows once more, the extended testsuite is running. Mark a few failing tests and skip a few tests which hang. This should at least bring the bot back to green without reverting the Python changes which are an improvement for the build system and enable another ~35% of the test suite which was previously disabled.
1 parent 8dd9a13 commit fb170fd

File tree

5 files changed

+12
-4
lines changed

5 files changed

+12
-4
lines changed

lldb/packages/Python/lldbsuite/test/commands/settings/TestSettings.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ def test_insert_before_and_after_target_run_args(self):
5858
'[3]: "b"',
5959
'[4]: "c"'])
6060

61+
@expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr44430")
6162
def test_replace_target_run_args(self):
6263
"""Test that 'replace target.run-args' works."""
6364
# Set the run-args and then replace the index-0 element.
@@ -106,6 +107,7 @@ def test_set_term_width(self):
106107
substrs=["term-width (int) = 70"])
107108

108109
# rdar://problem/10712130
110+
@skipIf(oslist=["windows"], bugnumber="llvm.org/pr44431")
109111
def test_set_frame_format(self):
110112
"""Test that 'set frame-format' with a backtick char in the format string works as well as fullpath."""
111113
self.build()
@@ -356,6 +358,7 @@ def test_settings_with_quotes(self):
356358
'thread-format (format-string) = "abc def "')
357359
self.runCmd('settings clear thread-format')
358360

361+
@expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr44430")
359362
def test_settings_with_trailing_whitespace(self):
360363

361364
# boolean

lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_command/TestBreakpointCommand.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ def not_test_breakpoint_command_sequence(self):
2222
self.build()
2323
self.breakpoint_command_sequence()
2424

25+
@skipIf(oslist=["windows"], bugnumber="llvm.org/pr44431")
2526
def test_script_parameters(self):
2627
"""Test a sequence of breakpoint command add, list, and delete."""
2728
self.build()

lldb/packages/Python/lldbsuite/test/functionalities/dead-strip/Makefile

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,13 @@ endif
66

77
ifeq "$(OS)" "Darwin"
88
LD_EXTRAS = -Xlinker -dead_strip
9-
else ifeq "$(OS)" "Windows_NT"
10-
CFLAGS_EXTRAS += /Gw /Gy
11-
LD_EXTRAS = -Xlinker /OPT:REF
129
else
1310
CFLAGS_EXTRAS += -fdata-sections -ffunction-sections
14-
LD_EXTRAS = -Wl,--gc-sections
11+
ifeq "$(OS)" "Windows_NT"
12+
LD_EXTRAS = -Xlinker /OPT:REF
13+
else
14+
LD_EXTRAS = -Wl,--gc-sections
15+
endif
1516
endif
1617

1718
MAKE_DSYM := NO

lldb/packages/Python/lldbsuite/test/functionalities/dead-strip/TestDeadStrip.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ class DeadStripTestCase(TestBase):
1414

1515
mydir = TestBase.compute_mydir(__file__)
1616

17+
@expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr44429")
1718
def test(self):
1819
"""Test breakpoint works correctly with dead-code stripping."""
1920
self.build()

lldb/packages/Python/lldbsuite/test/source-manager/TestSourceManager.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -171,6 +171,7 @@ def test_move_and_then_display_source(self):
171171
self.expect("source list -n main", SOURCE_DISPLAYED_CORRECTLY,
172172
substrs=['Hello world'])
173173

174+
@skipIf(oslist=["windows"], bugnumber="llvm.org/pr44431")
174175
def test_modify_source_file_while_debugging(self):
175176
"""Modify a source file while debugging the executable."""
176177
self.build()
@@ -236,6 +237,7 @@ def test_modify_source_file_while_debugging(self):
236237
SOURCE_DISPLAYED_CORRECTLY,
237238
substrs=['Hello lldb'])
238239

240+
@expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr44432")
239241
def test_set_breakpoint_with_absolute_path(self):
240242
self.build()
241243
hidden = self.getBuildArtifact("hidden")

0 commit comments

Comments
 (0)