Revert "[LLDB][GUI] Expand selected thread tree item by default"

This reverts commit fed25dd.

There has been sporadic failures in LLDB AArch64/Arm 32 buildbots since
this commit. I am temporarily reverting it see if it fixes the issue.

Differential Revision: https://reviews.llvm.org/D100243

Author: omjavaid

lldb/source/Core/IOHandlerCursesGUI.cpp

@@ -3768,13 +3768,8 @@ class TreeDelegate {
 
   virtual void TreeDelegateDrawTreeItem(TreeItem &item, Window &window) = 0;
   virtual void TreeDelegateGenerateChildren(TreeItem &item) = 0;
-  virtual void TreeDelegateUpdateSelection(TreeItem &root, int &selection_index,
-                                           TreeItem *&selected_item) {
-    return;
-  }
   virtual bool TreeDelegateItemSelected(
       TreeItem &item) = 0; // Return true if we need to update views
-  virtual bool TreeDelegateExpandRootByDefault() { return false; }
 };
 
 typedef std::shared_ptr<TreeDelegate> TreeDelegateSP;
@@ -3784,10 +3779,7 @@ class TreeItem {
   TreeItem(TreeItem *parent, TreeDelegate &delegate, bool might_have_children)
       : m_parent(parent), m_delegate(delegate), m_user_data(nullptr),
         m_identifier(0), m_row_idx(-1), m_children(),
-        m_might_have_children(might_have_children), m_is_expanded(false) {
-    if (m_parent == nullptr)
-      m_is_expanded = m_delegate.TreeDelegateExpandRootByDefault();
-  }
+        m_might_have_children(might_have_children), m_is_expanded(false) {}
 
   TreeItem &operator=(const TreeItem &rhs) {
     if (this != &rhs) {
@@ -4016,8 +4008,6 @@ class TreeWindowDelegate : public WindowDelegate {
       const int num_visible_rows = NumVisibleRows();
       m_num_rows = 0;
       m_root.CalculateRowIndexes(m_num_rows);
-      m_delegate_sp->TreeDelegateUpdateSelection(m_root, m_selected_row_idx,
-                                                 m_selected_item);
 
       // If we unexpanded while having something selected our total number of
       // rows is less than the num visible rows, then make sure we show all the
@@ -4319,7 +4309,7 @@ class ThreadsTreeDelegate : public TreeDelegate {
 public:
   ThreadsTreeDelegate(Debugger &debugger)
       : TreeDelegate(), m_thread_delegate_sp(), m_debugger(debugger),
-        m_stop_id(UINT32_MAX), m_update_selection(false) {
+        m_stop_id(UINT32_MAX) {
     FormatEntity::Parse("process ${process.id}{, name = ${process.name}}",
                         m_format);
   }
@@ -4347,7 +4337,6 @@ class ThreadsTreeDelegate : public TreeDelegate {
 
   void TreeDelegateGenerateChildren(TreeItem &item) override {
     ProcessSP process_sp = GetProcess();
-    m_update_selection = false;
     if (process_sp && process_sp->IsAlive()) {
       StateType state = process_sp->GetState();
       if (StateIsStoppedState(state, true)) {
@@ -4356,7 +4345,6 @@ class ThreadsTreeDelegate : public TreeDelegate {
           return; // Children are already up to date
 
         m_stop_id = stop_id;
-        m_update_selection = true;
 
         if (!m_thread_delegate_sp) {
           // Always expand the thread item the first time we show it
@@ -4368,58 +4356,24 @@ class ThreadsTreeDelegate : public TreeDelegate {
         TreeItem t(&item, *m_thread_delegate_sp, false);
         ThreadList &threads = process_sp->GetThreadList();
         std::lock_guard<std::recursive_mutex> guard(threads.GetMutex());
-        ThreadSP selected_thread = threads.GetSelectedThread();
         size_t num_threads = threads.GetSize();
         item.Resize(num_threads, t);
         for (size_t i = 0; i < num_threads; ++i) {
-          ThreadSP thread = threads.GetThreadAtIndex(i);
-          item[i].SetIdentifier(thread->GetID());
+          item[i].SetIdentifier(threads.GetThreadAtIndex(i)->GetID());
           item[i].SetMightHaveChildren(true);
-          if (selected_thread->GetID() == thread->GetID())
-            item[i].Expand();
         }
         return;
       }
     }
     item.ClearChildren();
   }
 
-  void TreeDelegateUpdateSelection(TreeItem &root, int &selection_index,
-                                   TreeItem *&selected_item) override {
-    if (!m_update_selection)
-      return;
-
-    ProcessSP process_sp = GetProcess();
-    if (!(process_sp && process_sp->IsAlive()))
-      return;
-
-    StateType state = process_sp->GetState();
-    if (!StateIsStoppedState(state, true))
-      return;
-
-    ThreadList &threads = process_sp->GetThreadList();
-    std::lock_guard<std::recursive_mutex> guard(threads.GetMutex());
-    ThreadSP selected_thread = threads.GetSelectedThread();
-    size_t num_threads = threads.GetSize();
-    for (size_t i = 0; i < num_threads; ++i) {
-      ThreadSP thread = threads.GetThreadAtIndex(i);
-      if (selected_thread->GetID() == thread->GetID()) {
-        selected_item = &root[i][thread->GetSelectedFrameIndex()];
-        selection_index = selected_item->GetRowIndex();
-        return;
-      }
-    }
-  }
-
   bool TreeDelegateItemSelected(TreeItem &item) override { return false; }
 
-  bool TreeDelegateExpandRootByDefault() override { return true; }
-
 protected:
   std::shared_ptr<ThreadTreeDelegate> m_thread_delegate_sp;
   Debugger &m_debugger;
   uint32_t m_stop_id;
-  bool m_update_selection;
   FormatEntity::Entry m_format;
 };