Skip to content

Commit fdd6c61

Browse files
committed
Feedback, add line numbers to test.
1 parent d9b0a9b commit fdd6c61

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUMCExpr.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ void AMDGPUVariadicMCExpr::printImpl(raw_ostream &OS,
4646
if ((It + 1) != Args.end())
4747
OS << ", ";
4848
}
49-
OS << ")";
49+
OS << ')';
5050
}
5151

5252
bool AMDGPUVariadicMCExpr::evaluateAsRelocatableImpl(

llvm/test/MC/AMDGPU/mcexpr_amd_err.s

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
// RUN: not llvm-mc -triple amdgcn-amd-amdhsa %s 2>&1 | FileCheck --check-prefix=ASM %s
22

3-
// ASM: error: empty max expression
4-
// ASM: error: missing expression
5-
// ASM: error: empty or expression
6-
// ASM: error: missing expression
7-
// ASM: error: unknown token in expression
8-
// ASM: error: missing expression
9-
// ASM: error: unexpected token in max expression
10-
// ASM: error: missing expression
11-
// ASM: error: unknown token in expression
12-
// ASM: error: missing expression
13-
// ASM: error: unexpected token in or expression
14-
// ASM: error: missing expression
3+
// ASM: 20:22: error: empty max expression
4+
// ASM: 20:22: error: missing expression
5+
// ASM: 21:20: error: empty or expression
6+
// ASM: 21:20: error: missing expression
7+
// ASM: 23:29: error: unknown token in expression
8+
// ASM: 23:29: error: missing expression
9+
// ASM: 24:32: error: unexpected token in max expression
10+
// ASM: 24:32: error: missing expression
11+
// ASM: 25:42: error: unknown token in expression
12+
// ASM: 25:42: error: missing expression
13+
// ASM: 26:38: error: unexpected token in or expression
14+
// ASM: 26:38: error: missing expression
1515

1616
.set one, 1
1717
.set two, 2

0 commit comments

Comments
 (0)