fixup! [clang-tidy] Added check to detect redundant inline keyword

Fixed a few more issues

- default methods should now trigger the warning
- functions and variables in anonymous namespace should also trigger this warning

Author: felix642

clang-tools-extra/clang-tidy/readability/RedundantInlineSpecifierCheck.cpp

@@ -55,16 +55,14 @@ getInlineTokenLocation(SourceRange RangeLocation, const SourceManager &Sources,
 
 void RedundantInlineSpecifierCheck::registerMatchers(MatchFinder *Finder) {
   Finder->addMatcher(
-      functionDecl(unless(isExpansionInSystemHeader()), isInlineSpecified(),
-                   anyOf(isConstexpr(), isDeleted(),
+      functionDecl(isInlineSpecified(), anyOf(isConstexpr(), isDeleted(), isDefaulted(), isInAnonymousNamespace(),
                          allOf(isDefinition(), hasAncestor(recordDecl()))))
           .bind("fun_decl"),
       this);
 
   Finder->addMatcher(
       varDecl(isInlineSpecified(),
-              anyOf(allOf(isConstexpr(), unless(isStaticStorageClass())),
-                    hasAncestor(recordDecl())))
+              anyOf(isInAnonymousNamespace(), allOf(isConstexpr(), hasAncestor(recordDecl()))))
           .bind("var_decl"),
       this);
 

clang-tools-extra/clang-tidy/readability/RedundantInlineSpecifierCheck.h

@@ -17,7 +17,7 @@ namespace clang::tidy::readability {
 /// declarations.
 ///
 /// For the user-facing documentation see:
-/// http://clang.llvm.org/extra/clang-tidy/checks/readability/readability-redundant-inline-specifier.html
+/// http://clang.llvm.org/extra/clang-tidy/checks/readability/redundant-inline-specifier.html
 class RedundantInlineSpecifierCheck : public ClangTidyCheck {
 public:
   RedundantInlineSpecifierCheck(StringRef Name, ClangTidyContext *Context)

clang-tools-extra/test/clang-tidy/checkers/readability/redundant-inline-specifier.cpp

@@ -28,6 +28,9 @@ class C
     // CHECK-MESSAGES: :[[@LINE-1]]:5: warning: function 'operator=' has inline specifier but is implicitly inlined [readability-redundant-inline-specifier]
     // CHECK-FIXES: C& operator=(const C&) = delete;
 
+    inline C(const C&) = default;
+    // CHECK-MESSAGES: :[[@LINE-1]]:5: warning: function 'C' has inline specifier but is implicitly inlined [readability-redundant-inline-specifier]
+
     constexpr inline C& operator=(int a);
     // CHECK-MESSAGES: :[[@LINE-1]]:15: warning: function 'operator=' has inline specifier but is implicitly inlined [readability-redundant-inline-specifier]
     // CHECK-FIXES: constexpr C& operator=(int a);
@@ -76,7 +79,7 @@ static constexpr inline int fn1(int i)
 namespace
 {
     inline int fn2(int i)
-    // CHECK-MESSAGES-NOT: :[[@LINE-1]]:5: warning: function 'fn2' has inline specifier but is implicitly inlined [readability-redundant-inline-specifier]
+    // CHECK-MESSAGES: :[[@LINE-1]]:5: warning: function 'fn2' has inline specifier but is implicitly inlined [readability-redundant-inline-specifier]
     {
         return i - 1;
     }
@@ -87,6 +90,9 @@ namespace
     {
         return i - 1;
     }
+
+    inline constexpr int MY_CONSTEXPR_VAR = 42;
+    // CHECK-MESSAGES: :[[@LINE-1]]:5: warning: variable 'MY_CONSTEXPR_VAR' has inline specifier but is implicitly inlined [readability-redundant-inline-specifier]
 }
 
 namespace ns